Correct environment support + upgrade dependencies #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin currently breaks the contract by not respecting the environment GoCD tells it to create an agent in. This can cause agents/instances to spin up that never get assigned jobs, and in some cases agents to get assigned jobs that they should not, due to hacks users use to set the environment with custom user data. This implements what is needed with a standard GoCD agent to conform to the spec at https://plugin-api.gocd.org/current/elastic-agents/#create-agent
Tests still fail though, some seem to depend on being able to do real stuff on AWS.
- Resolves vulnerabilities in transitive dependencies - Rationalises unneeded dependencies
|
@adrian-iriusrisk Is this something you're willing to evaluate and merge? PR looks a little big due to rationalising/removing commons-lang and some other dependencies that came over from the plugin template this was based on, but it should be reasonably straightforward. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20 by ensuring the GoCD-instructed environment is auto-registered by the agent. The plugin currently breaks the contract with GoCD which causes some confusion for users; see https://groups.google.com/g/go-cd/c/PAzY8Cw7Mxk/m/9Hbj8Fp9BAAJ
The fix is pretty simple given the current plugin design. Note that this change adds a warning in the job log if users have used the previous hacks to try and get environment support to work.
Also