Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct environment support + upgrade dependencies #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Correct environment support + upgrade dependencies #25

wants to merge 3 commits into from

Commits on Apr 26, 2024

  1. Add support to set the GoCD environment correctly 

    The plugin currently breaks the contract by not respecting the environment GoCD tells it to create an agent in. This can cause agents/instances to spin up that never get assigned jobs, and in some cases agents to get assigned jobs that they should not, due to hacks users use to set the environment with custom user data.

This implements what is needed with a standard GoCD agent to conform to the spec at https://plugin-api.gocd.org/current/elastic-agents/#create-agent
    @chadlwilson
    chadlwilson committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    31be31a View commit details
    Browse the repository at this point in the history

  2. Minor corrections to some tests to make them fail a bit more clearly 

    Tests still fail though, some seem to depend on being able to do real stuff on AWS.
    @chadlwilson
    chadlwilson committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    20ec23a View commit details
    Browse the repository at this point in the history

  3. Upgrade dependencies and Gradle version 

    - Resolves vulnerabilities in transitive dependencies
- Rationalises unneeded dependencies
    @chadlwilson
    chadlwilson committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f0c58ad View commit details
    Browse the repository at this point in the history