Fix #240 - Add support for weak references for some object refs. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds weak reference support, which means a reference between RPSL objects is checked for syntax, but not whether the object exists. This commit enables weak refs for all existing strong references of members, member-of, mp-members and mbrs-by-ref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IRRd 4.0.3, all references from
members,mp-member,mbrs-by-refandmember-ofare weak references. Theirsyntax is validated, e.g. for
as-setmembers, values mustbe a valid
as-setname or a valid AS number. However, thereis no validation on whether the objects actually exist.
It is also possible to delete e.g. a
route-set, even whenthe object is still set in
member-ofin arouteobject,or to reference a maintainer that does not exist in a
mbrs-by-ref.