-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] missing 1 required positional argument: 'config' -- immitation learning example #162
Comments
I looked at the line 127 of : source/standalone/workflows/robomimic/train.py and added config as the parameter
|
chaofiber
pushed a commit
to chaofiber/Orbit
that referenced
this issue
Dec 14, 2023
…m#162) # Description * This MR fixes the `VisualizationMarkers` class to use the `SpawnerCfg`. This makes it consistent with how assets are spawned and allows more variations. * The markers also support instanceable meshes. This is done by disabling their instancing (as PointInstancer does not support pre-instanced assets) and removing any rigid body APIs from the asset. Fixes isaac-sim#144 ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Screenshots https://github.com/isaac-orbit/orbit/assets/12863862/9d1b095b-99ee-4759-ba30-6175cc3b7d78 ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
Mayankm96
added a commit
that referenced
this issue
Dec 22, 2023
# Description * This MR fixes the `VisualizationMarkers` class to use the `SpawnerCfg`. This makes it consistent with how assets are spawned and allows more variations. * The markers also support instanceable meshes. This is done by disabling their instancing (as PointInstancer does not support pre-instanced assets) and removing any rigid body APIs from the asset. Fixes #144 ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Screenshots https://github.com/isaac-orbit/orbit/assets/12863862/9d1b095b-99ee-4759-ba30-6175cc3b7d78 ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems like the DataLoader function in robomimic is diff than what is expected here with a config parameter is a 2nd positional parameter now.
While running the command to train:
./orbit.sh -p source/standalone/workflows/robomimic/train.py --task Isaac-Lift-Franka-v0 --algo bc --dataset logs/robomimic/Isaac-Lift-Franka-v0/hdf_dataset.hdf5
I got the following error.
The text was updated successfully, but these errors were encountered: