-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Articulation initialization fails to reconstruct correct paths for its rigid bodies on assets with deep hierarchy #237
Comments
Thank you for bringing this up. We are aware of this issue and have reported it to the PhysX team to fix the regex parser on their side. The immediate fix is to ensure the asset follows a flat hierarchy of rigid links. If you don't care about all the bodies in the articulation, a more temporary solution is to replace the regex expression on the line you highlighted with the bodies you care about. Although ugly, hopefully, it lets you use the class. |
Thanks for the workarounds! |
Hi @Mayankm96, The interpretation of the regex expression seems to be very restrictive, or am I missing something? Any help would be appreciated. |
# Description The deprecation notice has been out for a while. The MR removes the body PhysX view from the rigid object and articulation classes. This is no longer needed as their respective root views expose all the data needed for them. This is a breaking change, and we lose compatibility with Isaac Sim 2023.1.1. Fixes isaac-sim#237 ## Type of change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
# Description The deprecation notice has been out for a while. The MR removes the body PhysX view from the rigid object and articulation classes. This is no longer needed as their respective root views expose all the data needed for them. This is a breaking change, and we lose compatibility with Isaac Sim 2023.1.1. Fixes isaac-sim#237 ## Type of change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Describe the bug
When an Articulation is initialized,
_initilize_imp()
function tries to construct the body paths by simply combining the root prim path and body names within the articulation tree:https://github.com/NVIDIA-Omniverse/orbit/blob/477cd6b3f6f37bdf8d7d8a47bf6ea8bb15376c3b/source/extensions/omni.isaac.orbit/omni/isaac/orbit/assets/articulation/articulation.py#L490-L502
However, this leads to incorrect paths for the bodies that are not right under the root prim.
For example, if there is an Xform to group a few bodies together:
the prim path for body3 is assumed to be on /robot/body3 rather than /robot/Xform/body3.
Eventually, the RigidBodyView is not constructed correctly, and this raises a RuntimeError at the following lines due to the mismatch of the
body_names
with thephysx_body_names
:https://github.com/NVIDIA-Omniverse/orbit/blob/477cd6b3f6f37bdf8d7d8a47bf6ea8bb15376c3b/source/extensions/omni.isaac.orbit/omni/isaac/orbit/assets/articulation/articulation.py#L510-L512
Steps to reproduce
Using any Articulation with a similar hierarchy reproduces the error.
System Info
Additional context
#200 and #208 are probably related to this.
Checklist
The text was updated successfully, but these errors were encountered: