Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Articulation initialization fails to reconstruct correct paths for its rigid bodies on assets with deep hierarchy #237

Closed
2 tasks done
ozhanozen opened this issue Feb 9, 2024 · 3 comments · Fixed by #643
Labels
bug Something isn't working

Comments

@ozhanozen
Copy link
Contributor

ozhanozen commented Feb 9, 2024

Describe the bug

When an Articulation is initialized, _initilize_imp() function tries to construct the body paths by simply combining the root prim path and body names within the articulation tree:

https://github.com/NVIDIA-Omniverse/orbit/blob/477cd6b3f6f37bdf8d7d8a47bf6ea8bb15376c3b/source/extensions/omni.isaac.orbit/omni/isaac/orbit/assets/articulation/articulation.py#L490-L502

However, this leads to incorrect paths for the bodies that are not right under the root prim.

For example, if there is an Xform to group a few bodies together:

robot (defaultPrim)
--- body1
--- body2
--- Xform
-------- body3 
-------- body4

the prim path for body3 is assumed to be on /robot/body3 rather than /robot/Xform/body3.

Eventually, the RigidBodyView is not constructed correctly, and this raises a RuntimeError at the following lines due to the mismatch of the body_names with the physx_body_names:

https://github.com/NVIDIA-Omniverse/orbit/blob/477cd6b3f6f37bdf8d7d8a47bf6ea8bb15376c3b/source/extensions/omni.isaac.orbit/omni/isaac/orbit/assets/articulation/articulation.py#L510-L512

Steps to reproduce

Using any Articulation with a similar hierarchy reproduces the error.

System Info

  • Commit: [939a768]
  • Isaac Sim Version: [2023.1.0-hotfix.1]
  • OS: [Ubuntu 20.04]
  • GPU: [RTX A6000]
  • CUDA: [12.0]
  • GPU Driver: [525.60.11]

Additional context

#200 and #208 are probably related to this.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have checked that the issue is not in running Isaac Sim itself and is related to the repo
@Mayankm96
Copy link
Contributor

Mayankm96 commented Feb 10, 2024

Thank you for bringing this up.

We are aware of this issue and have reported it to the PhysX team to fix the regex parser on their side. The immediate fix is to ensure the asset follows a flat hierarchy of rigid links.

If you don't care about all the bodies in the articulation, a more temporary solution is to replace the regex expression on the line you highlighted with the bodies you care about. Although ugly, hopefully, it lets you use the class.

@Mayankm96 Mayankm96 added the bug Something isn't working label Feb 10, 2024
@ozhanozen
Copy link
Contributor Author

Thank you for bringing this up.

We are aware of this issue and have reported it to the PhysX team to fix the regex parser on their side. The immediate fix is to ensure the asset follows a flat hierarchy of rigid links.

If you don't care about all the bodies in the articulation, a more temporary solution is to replace the regex expression on the line you highlighted with the bodies you care about. Although ugly, hopefully, it lets you use the class.

Thanks for the workarounds!

@axelgoedrich
Copy link

Hi @Mayankm96,
I am having the same issue @ozhanozen described.
I tried to replace the regex expression with multiple different versions, but none of them worked (ChatGPT couldn`t help me either).
For example: "/robot/(body1|body2)" works, but when I use "/robot/(body1|body2|Xform/body3)" I get the error Pattern '/robot/(body1|body2|Xform/body3)' did not match any rigid bodies.

The interpretation of the regex expression seems to be very restrictive, or am I missing something?

Any help would be appreciated.

mohanksriram pushed a commit to mohanksriram/IsaacLab that referenced this issue Jul 12, 2024
# Description

The deprecation notice has been out for a while. The MR removes the body
PhysX view from the rigid object and articulation classes. This is no
longer needed as their respective root views expose all the data needed
for them.

This is a breaking change, and we lose compatibility with Isaac Sim
2023.1.1.

Fixes isaac-sim#237

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this issue Aug 8, 2024
# Description

The deprecation notice has been out for a while. The MR removes the body
PhysX view from the rigid object and articulation classes. This is no
longer needed as their respective root views expose all the data needed
for them.

This is a breaking change, and we lose compatibility with Isaac Sim
2023.1.1.

Fixes isaac-sim#237

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants