Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the use of body view inside the asset classes #643

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

Mayankm96
Copy link
Contributor

@Mayankm96 Mayankm96 commented Jul 4, 2024

Description

The deprecation notice has been out for a while. The MR removes the body PhysX view from the rigid object and articulation classes. This is no longer needed as their respective root views expose all the data needed for them.

This is a breaking change, and we lose compatibility with Isaac Sim 2023.1.1.

Fixes #237

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 self-assigned this Jul 4, 2024
@Mayankm96 Mayankm96 added the bug Something isn't working label Jul 4, 2024
@Mayankm96 Mayankm96 merged commit da34688 into main Jul 5, 2024
3 checks passed
@Mayankm96 Mayankm96 deleted the fix/articulation-body-view branch July 5, 2024 10:34
@Mayankm96
Copy link
Contributor Author

I tested for anymal locomotion and training looks identical.

mohanksriram pushed a commit to mohanksriram/IsaacLab that referenced this pull request Jul 12, 2024
# Description

The deprecation notice has been out for a while. The MR removes the body
PhysX view from the rigid object and articulation classes. This is no
longer needed as their respective root views expose all the data needed
for them.

This is a breaking change, and we lose compatibility with Isaac Sim
2023.1.1.

Fixes isaac-sim#237

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
# Description

The deprecation notice has been out for a while. The MR removes the body
PhysX view from the rigid object and articulation classes. This is no
longer needed as their respective root views expose all the data needed
for them.

This is a breaking change, and we lose compatibility with Isaac Sim
2023.1.1.

Fixes isaac-sim#237

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants