Removes the use of body view inside the asset classes #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhoeller19
approved these changes
Jul 4, 2024
Mayankm96
force-pushed
the
fix/articulation-body-view
branch
from
bb2e54a
to
e25e289
Compare
|
I tested for anymal locomotion and training looks identical. |
mohanksriram
pushed a commit
to mohanksriram/IsaacLab
that referenced
this pull request
Jul 12, 2024
# Description The deprecation notice has been out for a while. The MR removes the body PhysX view from the rigid object and articulation classes. This is no longer needed as their respective root views expose all the data needed for them. This is a breaking change, and we lose compatibility with Isaac Sim 2023.1.1. Fixes isaac-sim#237 ## Type of change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description The deprecation notice has been out for a while. The MR removes the body PhysX view from the rigid object and articulation classes. This is no longer needed as their respective root views expose all the data needed for them. This is a breaking change, and we lose compatibility with Isaac Sim 2023.1.1. Fixes isaac-sim#237 ## Type of change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The deprecation notice has been out for a while. The MR removes the body PhysX view from the rigid object and articulation classes. This is no longer needed as their respective root views expose all the data needed for them.
This is a breaking change, and we lose compatibility with Isaac Sim 2023.1.1.
Fixes #237
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there