Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] 'unalias ORBIT_PATH &>/dev/null' inside setup_conda_env() prevents "orbit.sh --conda" to successfully exit #377

Closed
3 tasks done
ozhanozen opened this issue Apr 22, 2024 · 0 comments · Fixed by #378
Closed
3 tasks done

[Bug Report] 'unalias ORBIT_PATH &>/dev/null' inside setup_conda_env() prevents "orbit.sh --conda" to successfully exit #377

ozhanozen opened this issue Apr 22, 2024 · 0 comments · Fixed by #378

Comments

@ozhanozen
Copy link
Contributor

ozhanozen commented Apr 22, 2024 •
edited
Loading

'unalias ORBIT_PATH &>/dev/null' inside setup_conda_env() prevents orbit.sh --conda to successfully exit, as the "unset" command rather than "unalias" should be used for environment variables (e.g., ORBIT_PATH). This is a problem, e.g., when a custom dockerfile is used to directly install conda during the image build process: the image build process is interrupted.

Steps to reproduce

You can see that the last lines of setup_conda_env() are not executed when installing the orbit conda env from within the container, or one gets exit code: 1 when installing the conda env from a dockerfile.

Solution

Before:
https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148
After:
'unset ORBIT_PATH' \

I am creating a PR directly as it is a tiny fix that does not seem to break anything.

System Info

Commit: [a642b8e]
Isaac Sim Version: [2023.1.1]
OS: [Ubuntu 20.04]
GPU: [RTX A6000]
CUDA: [12.0]
GPU Driver: [525.60.11]

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have checked that the issue is not in running Isaac Sim itself and is related to the repo

Acceptance Criteria

  • orbit.sh --conda should exit successfully
@ozhanozen ozhanozen mentioned this issue Apr 22, 2024
Merged
7 tasks
Mayankm96 pushed a commit that referenced this issue Apr 22, 2024
@ozhanozen
Fixes setup_conda_env: changes 'unalias' to 'unset' for ORBIT_PATH (#378
d8377ee 
)

# Description

The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()`
prevents `orbit.sh --conda` to successfully exit. The "`unset`" command
rather than "`unalias`" should be used for environment variables (e.g.,
`ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used
to directly install conda during the image build process: the image
build process is interrupted.

Fixes #377

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

Before:

https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148
After:
`'unset ORBIT_PATH' \`

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Mayankm96 pushed a commit that referenced this issue Apr 22, 2024
@ozhanozen @Mayankm96
Changes 'unalias' to 'unset' inside setup_conda_env in orbit.sh (#378)
1ecb2d1 
The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()`
prevents `orbit.sh --conda` to successfully exit. The "`unset`" command
rather than "`unalias`" should be used for environment variables (e.g.,
`ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used
to directly install conda during the image build process: the image
build process is interrupted.

Fixes #377

- Bug fix (non-breaking change which fixes an issue)

Before:

https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148
After:
`'unset ORBIT_PATH' \`

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Mayankm96 pushed a commit that referenced this issue Apr 22, 2024
@ozhanozen @Mayankm96
Changes 'unalias' to 'unset' inside setup_conda_env in orbit.sh (#378)
7cc56c3 
The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()`
prevents `orbit.sh --conda` to successfully exit. The "`unset`" command
rather than "`unalias`" should be used for environment variables (e.g.,
`ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used
to directly install conda during the image build process: the image
build process is interrupted.

Fixes #377

- Bug fix (non-breaking change which fixes an issue)

Before:

https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148
After:
`'unset ORBIT_PATH' \`

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this issue Aug 8, 2024
@ozhanozen @Mayankm96
Changes 'unalias' to 'unset' inside setup_conda_env in orbit.sh (is…
fe56ae9 
…aac-sim#378)

The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()`
prevents `orbit.sh --conda` to successfully exit. The "`unset`" command
rather than "`unalias`" should be used for environment variables (e.g.,
`ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used
to directly install conda during the image build process: the image
build process is interrupted.

Fixes isaac-sim#377

- Bug fix (non-breaking change which fixes an issue)

Before:

https://github.com/NVIDIA-Omniverse/orbit/blob/f15ccae6d24a8cf1147f53645db26ecb145462b3/orbit.sh#L148
After:
`'unset ORBIT_PATH' \`

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ozhanozen