Changes 'unalias' to 'unset' inside setup_conda_env in orbit.sh
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozhanozen
changed the title
Mayankm96
approved these changes
Apr 22, 2024
|
Thanks a lot for the fix! :) |
Mayankm96
changed the title
setup_conda_env in orbit.sh
Mayankm96
pushed a commit
that referenced
this pull request
Apr 22, 2024
The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()` prevents `orbit.sh --conda` to successfully exit. The "`unset`" command rather than "`unalias`" should be used for environment variables (e.g., `ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used to directly install conda during the image build process: the image build process is interrupted. Fixes #377 - Bug fix (non-breaking change which fixes an issue) Before: https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148 After: `'unset ORBIT_PATH' \` - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Mayankm96
pushed a commit
that referenced
this pull request
Apr 22, 2024
The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()` prevents `orbit.sh --conda` to successfully exit. The "`unset`" command rather than "`unalias`" should be used for environment variables (e.g., `ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used to directly install conda during the image build process: the image build process is interrupted. Fixes #377 - Bug fix (non-breaking change which fixes an issue) Before: https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148 After: `'unset ORBIT_PATH' \` - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
wangyan-hlab
pushed a commit
to wangyan-hlab/IsaacLab
that referenced
this pull request
Apr 23, 2024
# Description Recently, tests were discovered that import from `utils`: `from omni.isaac.orbit.utils` cause a `ModuleNotFoundError` for `warp` within a container workflow fail as they weren't starting up the simulation app. This PR fixes this issue by setting up simulation app in any tests that need it. Fixes isaac-sim#372 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description Recently, tests were discovered that import from `utils`: `from omni.isaac.orbit.utils` cause a `ModuleNotFoundError` for `warp` within a container workflow fail as they weren't starting up the simulation app. This PR fixes this issue by setting up simulation app in any tests that need it. Fixes isaac-sim#372 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
…aac-sim#378) The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()` prevents `orbit.sh --conda` to successfully exit. The "`unset`" command rather than "`unalias`" should be used for environment variables (e.g., `ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used to directly install conda during the image build process: the image build process is interrupted. Fixes isaac-sim#377 - Bug fix (non-breaking change which fixes an issue) Before: https://github.com/NVIDIA-Omniverse/orbit/blob/f15ccae6d24a8cf1147f53645db26ecb145462b3/orbit.sh#L148 After: `'unset ORBIT_PATH' \` - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The line
'unalias ORBIT_PATH &>/dev/null'insidesetup_conda_env()preventsorbit.sh --condato successfully exit. The "unset" command rather than "unalias" should be used for environment variables (e.g.,ORBIT_PATH). This is a problem, e.g., when a custom dockerfile is used to directly install conda during the image build process: the image build process is interrupted.Fixes #377
Type of change
Screenshots
Before:
https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148
After:
'unset ORBIT_PATH' \Checklist
pre-commitchecks with./orbit.sh --format./orbit.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there