Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pytest unit tests on circleci #50

Merged
merged 6 commits into from
Jul 23, 2022
Merged

Run pytest unit tests on circleci #50

merged 6 commits into from
Jul 23, 2022

Conversation

rtburns-jpl
Copy link
Member

@rtburns-jpl rtburns-jpl commented Jun 30, 2022 •
edited
Loading

This puts the circleci job at parity with the github action, so the github action is also removed in this PR.

@yunjunz yunjunz requested review from LiangJYu and yunjunz July 22, 2022 18:55
yunjunz
yunjunz reviewed Jul 22, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@yunjunz yunjunz requested a review from vbrancat July 22, 2022 19:00
yunjunz
yunjunz approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @rtburns-jpl.

LiangJYu
LiangJYu approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@rtburns-jpl rtburns-jpl merged commit 6a391db into main Jul 23, 2022
@rtburns-jpl rtburns-jpl deleted the circleci branch July 23, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

@LiangJYu LiangJYu LiangJYu approved these changes

@vbrancat vbrancat Awaiting requested review from vbrancat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtburns-jpl @LiangJYu @yunjunz