Thermal noise Correction and EAP phase compensation #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the main branch of this fork to update after `s1_annotation.py`
…r implementation for thermal and EAP correction
LiangJYu
reviewed
Aug 23, 2022
… `Sentinel1BurstSlc`
Readability improvement on equation Co-authored-by: Liang Yu <liangjyu@gmail.com>
Removing commented out code Co-authored-by: Liang Yu <liangjyu@gmail.com>
Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <liangjyu@gmail.com>
Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <liangjyu@gmail.com>
Removing the commented out codes Co-authored-by: Liang Yu <liangjyu@gmail.com>
improvement on code brevity Co-authored-by: Liang Yu <liangjyu@gmail.com>
renaming variable for better clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
renaming variable name for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
Bump isce3 to 0.8 and refresh CI specfile (isce-framework#66)
variable name revised for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
variable renamed for clarity Co-authored-by: Liang Yu <liangjyu@gmail.com>
improvement on docstring Co-authored-by: Liang Yu <liangjyu@gmail.com>
fix on docstring Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
unnecessary comment removed Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
…iguration id of the AUX_CAL .zip
LiangJYu
reviewed
Sep 15, 2022
gshiroma
reviewed
Sep 22, 2022
There was a problem hiding this comment.
Thank you so much, @seongsujeong, for working on this PR. This is really important for RTC and CSLC. As we discussed offline, I think we need aux_cal in this PR. Otherwise, we'll have problems processing old data. In addition, I also added a few comments below.
added 5 commits
September 22, 2022 16:31
gshiroma
reviewed
Oct 7, 2022
gshiroma
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Thank you, @seongsujeong , for addressing all my comments. I have one last suggestion below, but I think this PR is already good for merging.
Ah.. Just please make sure to resolve all conflicts before merging it. |
Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add thermal noise correction and EAP phase compensation features into OPERA workflow.