Updating the main branch of this fork to update after s1_annotation.py
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add basic circleci config * Add specfile and auto-specfile-updater script to .circleci directory * Update circleci config to use conda with specfile for all deps * Add sh shebang * Quote sh variable expansion
* Add orbit download functionality * Move URL internal to get_orbit_dict * Improve variable clarity * Move main function to the top * Add check to avoid orbit download if exists * Reuse parse_filename in get_filename_tokens
* adding a text file with esa burst id and max id number of each id * make the burst IDs consistent with ESA * move sentinel1_track_burst_id.txt * add the data file to setup.cfg and MANIFEST.in * dict to array
* Update version for point release
+ setup.cfg: setup the version number via `version.release_version`, instead of going through `__init__`, to avoid the circular imports that causes the pip install "ModuleNotFoundError" + setup.cfg: add `install_requires` and remove `[opptions.package_data]` to be consistent with compass + __inti__.py: use absolute module import, to be consistent with the good style from pyresample module + version.py: remove the duplicated `__version__` variable.
* Update specfiles * Run pytests on circleci * Add backoff to deps * Remove github action * typo fix * Comment out S1 test data download Currently unused Co-authored-by: Zhang Yunjun <yunjunzgeo@gmail.com>
* added manifest.safe to test SAFE/zip * updated burst ID format * fixed directory structure in zip to match S1 SAFE spec * documentation fix
* annotation reader (s1_annotation.py) init. commit * s1_annotation.py - rev1 after the suggestion by @gshiroma * s1_annotation.py - Pylinted to be more conform to PEP8 * annotation objects are attributes of `Sentinel1BurstSlc` * s1_annotation.py : Classes for Burst-wide information * s1_reader.py - annotation information are stored in each Sentinel1BurstSlc instances * Update src/s1reader/s1_reader.py - comment from Liang Co-authored-by: Liang Yu <liangjyu@gmail.com> * Fix on edits committed on another branch * removing placeholder Co-authored-by: Liang Yu <liangjyu@gmail.com> * get_ipf_version - revision by @LiangJYu Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py - remove placeholder Co-authored-by: Liang Yu <liangjyu@gmail.com> * moving the single-use variables closer to where they are used. Co-authored-by: Liang Yu <liangjyu@gmail.com> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <liangjyu@gmail.com> * s1_annotation.py - readibility improvement * Update on docstring for `AnnotationBase` Co-authored-by: Liang Yu <liangjyu@gmail.com> * revision on error message Co-authored-by: Liang Yu <liangjyu@gmail.com> * Addressing comments by @LiangJYu and @vbrancat in PR #48 * s1_annotation.py - code cleanup Co-authored-by: Liang Yu <liangjyu@gmail.com> * s1_annotation.py - readability improvement Co-authored-by: Liang Yu <liangjyu@gmail.com> * readibility improvement * changing the datatype of IPF version to version.Version. Changing the affected functions accordingly. * space between args in _parse_list * addressing the comments by @vbrancat * added manifest.safe to test SAFE/zip * updated burst ID format * fixed directory structure in zip to match S1 SAFE spec * Update src/s1reader/s1_annotation.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Update src/s1reader/s1_annotation.py Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * s1_annotation.py - fixing the logic to add margin to azimuth noise LUT Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * s1_reader.py - removing lines that commented out Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * s1_reader.py - further removal of lines that commented out Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com> * Addressing comments by @gshiroma and other minor fix * Addressing codacy issues * Taking care of codacy issues * Fixing Codacy issue Co-authored-by: Seongsu Jeong <seongsu.jeong@jpl.nasa.gov> Co-authored-by: Liang Yu <liangjyu@gmail.com> Co-authored-by: Gustavo H. X. Shiroma <52007211+gshiroma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the main branch of this fork to update after
s1_annotation.py