Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and docs improvement of AABB tensor class #6486

Merged

Conversation

saurabheights
Copy link
Contributor

Type

Motivation and Context

Fixes a bug in CreateFromPoints method of AABB.
Improves textual description of AABB class.
Improves missing docs in doxygen output and incorrect docs and incorrect messages.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a minor issue with ToString() test.
LGTM. Thanks @saurabheights

@ssheorey ssheorey force-pushed the khanduja/review_aabb_legacy_vs_tensor branch from 8a37b07 to 9019126 Compare November 14, 2023 06:16
@ssheorey ssheorey force-pushed the khanduja/review_aabb_legacy_vs_tensor branch from 9019126 to 843ba13 Compare November 14, 2023 19:37
@ssheorey ssheorey merged commit 392fcb9 into isl-org:master Nov 14, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants