HashfileDB: support migration between ODBs #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
force-pushed
the
hashfiledb-migrate
branch
from
1c61ada
to
a46fc1b
Compare
2 tasks
pmrowla
force-pushed
the
hashfiledb-migrate
branch
from
a46fc1b
to
055739c
Compare
pmrowla
commented
Jun 13, 2023
| return dest.add(paths, src.fs, oids, hardlink=True, callback=callback) | ||
|
|
||
|
|
||
| def prepare( |
There was a problem hiding this comment.
I separated prepare and migrate because from the DVC UI perspective it's two distinct operations with separate progress bars (one for the hashing operation and one for the transfer)
There was a problem hiding this comment.
Looks pretty nice. Need to do the same in checkout and fetch later 🙂
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 61.59% 61.03% -0.57%
==========================================
Files 55 56 +1
Lines 3776 3811 +35
Branches 676 681 +5
==========================================
Hits 2326 2326
- Misses 1310 1345 +35
Partials 140 140
☔ View full report in Codecov by Sentry. |
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.