Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache migrate: add utility for migrating local cache files to 3.x #9591

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Jun 13, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

related: #4658

requires iterative/dvc-data#389

Adds dvc cache migrate to move local cache files into 3.x cache location and then link the 2.x location -> 3.x location

@pmrowla pmrowla self-assigned this Jun 13, 2023
@pmrowla
Copy link
Contributor Author

pmrowla commented Jun 13, 2023

migrate

asciinema recording is too big to be uploaded to the asciinema site, the gif conversion is a bit off but should be close enough

@pmrowla pmrowla marked this pull request as ready for review June 13, 2023 10:26
@pmrowla pmrowla requested a review from dberenbaum June 13, 2023 10:26
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 37.03% and project coverage change: -0.05 ⚠️

Comparison is base (5c1487e) 90.55% compared to head (40c0a69) 90.51%.

❗ Current head 40c0a69 differs from pull request most recent head 536b6a8. Consider uploading reports for the commit 536b6a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9591      +/-   ##
==========================================
- Coverage   90.55%   90.51%   -0.05%     
==========================================
  Files         470      470              
  Lines       35939    35964      +25     
  Branches     5180     5183       +3     
==========================================
+ Hits        32545    32553       +8     
- Misses       2800     2817      +17     
  Partials      594      594              
Impacted Files Coverage Ξ”
dvc/cachemgr.py 73.68% <12.50%> (-16.48%) ⬇️
dvc/commands/cache.py 88.23% <72.72%> (-4.45%) ⬇️

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum dberenbaum mentioned this pull request Jun 13, 2023
4 tasks
@pmrowla pmrowla merged commit 5ec4fa4 into iterative:main Jun 13, 2023
@pmrowla pmrowla deleted the 3.x-cache-migrate branch June 13, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants