Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User: Remove broken Google login #3893

Merged
merged 12 commits into from
Jun 11, 2023

Conversation

SamantazFox
Copy link
Member

@SamantazFox SamantazFox commented Jun 10, 2023

Extracted from #3020

Closes #2098

@unixfox
Copy link
Member

unixfox commented Jun 10, 2023

Very good idea, I also thought about removing that.

Do note that the tests are failing.

@SamantazFox
Copy link
Member Author

Yes, I forgot to remove some code at various places ^^ It's fixed

@SamantazFox SamantazFox changed the title Remove broken google login User: Remove broken Google login Jun 10, 2023
@SamantazFox SamantazFox requested a review from unixfox June 10, 2023 19:00
@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Jun 11, 2023
@SamantazFox SamantazFox merged commit c3a3f98 into iv-org:master Jun 11, 2023
@SamantazFox SamantazFox removed the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Jun 11, 2023
@SamantazFox SamantazFox deleted the remove-broken-google-login branch June 11, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Attempts to login with Google not successful
2 participants