-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User: Remove broken Google login #3893
Merged
SamantazFox
merged 12 commits into
iv-org:master
from
SamantazFox:remove-broken-google-login
Jun 11, 2023
Merged
User: Remove broken Google login #3893
SamantazFox
merged 12 commits into
iv-org:master
from
SamantazFox:remove-broken-google-login
Jun 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
requested review from
TheFrenchGhosty,
unixfox and
a team
as code owners
June 10, 2023 17:09
SamantazFox
force-pushed
the
remove-broken-google-login
branch
from
June 10, 2023 17:23
cde0fb1
to
8381808
Compare
unixfox
approved these changes
Jun 10, 2023
Very good idea, I also thought about removing that. Do note that the tests are failing. |
SamantazFox
force-pushed
the
remove-broken-google-login
branch
from
June 10, 2023 18:05
8381808
to
daef81c
Compare
Yes, I forgot to remove some code at various places ^^ It's fixed |
SamantazFox
changed the title
Remove broken google login
User: Remove broken Google login
Jun 10, 2023
unixfox
approved these changes
Jun 10, 2023
SamantazFox
added
the
need-testing
This feature needs to be deployed and tested to see if it's working, and doesn't break something
label
Jun 11, 2023
SamantazFox
force-pushed
the
remove-broken-google-login
branch
from
June 11, 2023 14:35
daef81c
to
b06c87f
Compare
SamantazFox
removed
the
need-testing
This feature needs to be deployed and tested to see if it's working, and doesn't break something
label
Jun 11, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3020
Closes #2098