Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the failing tests for the acos method in PyTorch frontend. #21447

Closed
wants to merge 1 commit into from
Closed

Conversation

he11owthere
Copy link
Contributor

closes #20773

image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 8, 2023
@vedpatwardhan
Copy link
Contributor

Hey @he11owthere, actually the function supports bfloat16 but there's an issue in the ivy.Array.__repr__ method which is currently being fixed. Could you please close this and the other PRs created for a similar reason?
Thanks for helping us spot the issue, the ivy.Array.__repr__ method is the root cause, all these functions should work as expected once that's fixed 😄

@he11owthere
Copy link
Contributor Author

@vedpatwardhan Alright I am closing it right away along with the other PRs which are inappropriate by checking if the data types are supported by the original PyTorch functions. I will try my best to see if there is any way to fix the function you mentioned above. Sorry if I caused any problem to the codebase and will try my best to be helpful. Thank you very much! 😊

@he11owthere he11owthere closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tensor.test_torch_acos
4 participants