Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed erf_ method in the PyTorch frontend. #22718

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Fixed erf_ method in the PyTorch frontend. #22718

merged 5 commits into from
Aug 29, 2023

Conversation

he11owthere
Copy link
Contributor

@he11owthere he11owthere commented Aug 28, 2023

This method was intended to execute an in-place operation on the erf method, but it lacked a return value.

image

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 28, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@he11owthere
Copy link
Contributor Author

Please remove "bfloat16" from with_supported_dtypes decorator before running the tests until the issue with ivy.Array.repr method has been fixed as mentioned by Ved in #21447. Thank you! 🙂

Copy link
Contributor

@Sam-Armstrong Sam-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@he11owthere these changes look very reasonable to me, thanks for the contribution!

@Sam-Armstrong
Copy link
Contributor

Sam-Armstrong commented Aug 29, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@Sam-Armstrong Sam-Armstrong merged commit 43f4291 into ivy-llc:main Aug 29, 2023
105 of 132 checks passed
arshPratap pushed a commit to arshPratap/ivy that referenced this pull request Sep 11, 2023
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants