-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed erf_ method in the PyTorch frontend. #22718
Conversation
Thanks for contributing to Ivy! 😊👏 |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
Please remove "bfloat16" from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@he11owthere these changes look very reasonable to me, thanks for the contribution!
ivy-gardener |
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
This method was intended to execute an in-place operation on the
erf
method, but it lacked a return value.