-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add torch frontend masked_scatter and masked_scatter_ #28783
add torch frontend masked_scatter and masked_scatter_ #28783
Conversation
@Sam-Armstrong Do you know why while the helper function I wrote generates input tensors of the same size (that follows the broadcastable requirement shown here https://pytorch.org/docs/stable/generated/torch.Tensor.masked_scatter_.html#torch.Tensor.masked_scatter_), the test still sometime fail with error of unable to broadcast between two arrays. |
@Daniel4078 I've fixed the implementation for |
…ed, during with the dtype is passed as None when converting result back to tensor for return
@Sam-Armstrong I have done the changes you asked for, now only the paddle backend tests fail probabily due to someone forgot to pass the dtype parameter when converting to tensor in the implementaiton of put_along_axis in paddle backend. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @Daniel4078 😁
PR Description
Related Issue
Closes #
Checklist
Socials