Make BPF Loader static (bp solana-labs#11516) (solana-labs#11865)

* Make BPF Loader static (solana-labs#11516)

(cherry picked from commit 7c736f7)

# Conflicts:
#	Cargo.lock
#	core/Cargo.toml
#	core/src/lib.rs
#	core/src/validator.rs
#	genesis/src/main.rs
#	programs/bpf/tests/programs.rs
#	runtime/src/builtin_programs.rs
#	runtime/src/lib.rs

* resolve conflicts

* nudge

Co-authored-by: Jack May <jack@solana.com>

core/Cargo.toml

@@ -43,7 +43,6 @@ serde = "1.0.110"
 serde_derive = "1.0.103"
 serde_json = "1.0.53"
 solana-account-decoder = { path = "../account-decoder", version = "1.2.27" }
-solana-bpf-loader-program = { path = "../programs/bpf_loader", version = "1.2.27" }
 solana-budget-program = { path = "../programs/budget", version = "1.2.27" }
 solana-clap-utils = { path = "../clap-utils", version = "1.2.27" }
 solana-client = { path = "../client", version = "1.2.27" }

core/src/lib.rs

@@ -71,9 +71,6 @@ pub mod verified_vote_packets;
 pub mod weighted_shuffle;
 pub mod window_service;
 
-#[macro_use]
-extern crate solana_bpf_loader_program;
-
 #[macro_use]
 extern crate solana_budget_program;
 

core/src/validator.rs

@@ -860,13 +860,6 @@ impl TestValidator {
         genesis_config
             .native_instruction_processors
             .push(solana_budget_program!());
-        genesis_config
-            .native_instruction_processors
-            .push(solana_bpf_loader_program!());
-        genesis_config
-            .native_instruction_processors
-            .push(solana_bpf_loader_deprecated_program!());
-
         genesis_config.rent.lamports_per_byte_year = 1;
         genesis_config.rent.exemption_threshold = 1.0;
         genesis_config.fee_rate_governor = FeeRateGovernor::new(fees, 0);

genesis-programs/src/lib.rs

@@ -1,7 +1,3 @@
-use solana_sdk::{
-    clock::Epoch, genesis_config::OperatingMode, inflation::Inflation, pubkey::Pubkey,
-};
-
 #[macro_use]
 extern crate solana_bpf_loader_program;
 #[macro_use]
@@ -13,6 +9,10 @@ extern crate solana_vest_program;
 
 use log::*;
 use solana_runtime::bank::{Bank, EnteredEpochCallback};
+use solana_sdk::{
+    clock::Epoch, entrypoint_native::ProcessInstructionWithContext, genesis_config::OperatingMode,
+    inflation::Inflation, pubkey::Pubkey,
+};
 
 pub fn get_inflation(operating_mode: OperatingMode, epoch: Epoch) -> Option<Inflation> {
     match operating_mode {
@@ -44,22 +44,27 @@ pub fn get_inflation(operating_mode: OperatingMode, epoch: Epoch) -> Option<Infl
     }
 }
 
-pub fn get_programs(operating_mode: OperatingMode, epoch: Epoch) -> Option<Vec<(String, Pubkey)>> {
+enum Program {
+    Native((String, Pubkey)),
+    BuiltinLoader((String, Pubkey, ProcessInstructionWithContext)),
+}
+
+fn get_programs(operating_mode: OperatingMode, epoch: Epoch) -> Option<Vec<Program>> {
     match operating_mode {
         OperatingMode::Development => {
             if epoch == 0 {
                 // Programs used for testing
                 Some(vec![
-                    solana_bpf_loader_program!(),
-                    solana_bpf_loader_deprecated_program!(),
-                    solana_vest_program!(),
-                    solana_budget_program!(),
-                    solana_exchange_program!(),
+                    Program::BuiltinLoader(solana_bpf_loader_program!()),
+                    Program::BuiltinLoader(solana_bpf_loader_deprecated_program!()),
+                    Program::Native(solana_vest_program!()),
+                    Program::Native(solana_budget_program!()),
+                    Program::Native(solana_exchange_program!()),
                 ])
             } else if epoch == std::u64::MAX {
                 // The epoch of std::u64::MAX is a placeholder and is expected
                 // to be reduced in a future network update.
-                Some(vec![solana_bpf_loader_program!()])
+                Some(vec![Program::BuiltinLoader(solana_bpf_loader_program!())])
             } else {
                 None
             }
@@ -68,7 +73,10 @@ pub fn get_programs(operating_mode: OperatingMode, epoch: Epoch) -> Option<Vec<(
             if epoch == std::u64::MAX {
                 // The epoch of std::u64::MAX is a placeholder and is expected
                 // to be reduced in a future network update.
-                Some(vec![solana_bpf_loader_program!(), solana_vest_program!()])
+                Some(vec![
+                    Program::BuiltinLoader(solana_bpf_loader_program!()),
+                    Program::Native(solana_vest_program!()),
+                ])
             } else {
                 None
             }
@@ -77,29 +85,59 @@ pub fn get_programs(operating_mode: OperatingMode, epoch: Epoch) -> Option<Vec<(
             if epoch == std::u64::MAX {
                 // The epoch of std::u64::MAX is a placeholder and is expected
                 // to be reduced in a future network update.
-                Some(vec![solana_bpf_loader_program!(), solana_vest_program!()])
+                Some(vec![
+                    Program::BuiltinLoader(solana_bpf_loader_program!()),
+                    Program::Native(solana_vest_program!()),
+                ])
             } else {
                 None
             }
         }
     }
 }
 
+pub fn get_native_programs(
+    operating_mode: OperatingMode,
+    epoch: Epoch,
+) -> Option<Vec<(String, Pubkey)>> {
+    match get_programs(operating_mode, epoch) {
+        Some(programs) => {
+            let mut native_programs = vec![];
+            for program in programs {
+                if let Program::Native((string, key)) = program {
+                    native_programs.push((string, key));
+                }
+            }
+            Some(native_programs)
+        }
+        None => None,
+    }
+}
+
 pub fn get_entered_epoch_callback(operating_mode: OperatingMode) -> EnteredEpochCallback {
     Box::new(move |bank: &mut Bank| {
-        info!(
-            "Entering epoch {} with operating_mode {:?}",
-            bank.epoch(),
-            operating_mode
-        );
         if let Some(inflation) = get_inflation(operating_mode, bank.epoch()) {
             info!("Entering new epoch with inflation {:?}", inflation);
             bank.set_inflation(inflation);
         }
-        if let Some(new_programs) = get_programs(operating_mode, bank.epoch()) {
-            for (name, program_id) in new_programs.iter() {
-                info!("Registering {} at {}", name, program_id);
-                bank.add_native_program(name, program_id);
+        if let Some(programs) = get_programs(operating_mode, bank.epoch()) {
+            for program in programs {
+                match program {
+                    Program::Native((name, program_id)) => {
+                        bank.add_native_program(&name, &program_id);
+                    }
+                    Program::BuiltinLoader((
+                        name,
+                        program_id,
+                        process_instruction_with_context,
+                    )) => {
+                        bank.add_builtin_loader(
+                            &name,
+                            program_id,
+                            process_instruction_with_context,
+                        );
+                    }
+                }
             }
         }
         if OperatingMode::Stable == operating_mode {
@@ -118,8 +156,13 @@ mod tests {
     #[test]
     fn test_id_uniqueness() {
         let mut unique = HashSet::new();
-        let ids = get_programs(OperatingMode::Development, 0).unwrap();
-        assert!(ids.into_iter().all(move |id| unique.insert(id)));
+        let programs = get_programs(OperatingMode::Development, 0).unwrap();
+        for program in programs {
+            match program {
+                Program::Native((name, id)) => assert!(unique.insert((name, id))),
+                Program::BuiltinLoader((name, id, _)) => assert!(unique.insert((name, id))),
+            }
+        }
     }
 
     #[test]
@@ -137,7 +180,18 @@ mod tests {
             get_programs(OperatingMode::Development, 0).unwrap().len(),
             5
         );
-        assert_eq!(get_programs(OperatingMode::Development, 1), None);
+        assert!(get_programs(OperatingMode::Development, 1).is_none());
+    }
+
+    #[test]
+    fn test_native_development_programs() {
+        assert_eq!(
+            get_native_programs(OperatingMode::Development, 0)
+                .unwrap()
+                .len(),
+            3
+        );
+        assert!(get_native_programs(OperatingMode::Development, 1).is_none());
     }
 
     #[test]
@@ -155,7 +209,7 @@ mod tests {
 
     #[test]
     fn test_softlaunch_programs() {
-        assert_eq!(get_programs(OperatingMode::Stable, 1), None);
+        assert!(get_programs(OperatingMode::Stable, 1).is_none());
         assert!(get_programs(OperatingMode::Stable, std::u64::MAX).is_some());
     }
 }

genesis/src/main.rs

@@ -468,7 +468,7 @@ fn main() -> Result<(), Box<dyn error::Error>> {
     );
 
     let native_instruction_processors =
-        solana_genesis_programs::get_programs(operating_mode, 0).unwrap_or_else(|| vec![]);
+        solana_genesis_programs::get_native_programs(operating_mode, 0).unwrap_or_else(Vec::new);
     let inflation = solana_genesis_programs::get_inflation(operating_mode, 0).unwrap();
 
     let mut genesis_config = GenesisConfig {

ledger/src/blockstore_processor.rs

@@ -300,11 +300,11 @@ pub fn process_blockstore(
     }
 
     // Setup bank for slot 0
-    let bank0 = Arc::new(Bank::new_with_paths(
-        &genesis_config,
-        account_paths,
-        &opts.frozen_accounts,
-    ));
+    let mut bank0 = Bank::new_with_paths(&genesis_config, account_paths, &opts.frozen_accounts);
+    let callback =
+        solana_genesis_programs::get_entered_epoch_callback(genesis_config.operating_mode);
+    callback(&mut bank0);
+    let bank0 = Arc::new(bank0);
     info!("processing ledger for slot 0...");
     let recyclers = VerifyRecyclers::default();
     process_bank_0(&bank0, blockstore, &opts, &recyclers)?;

local-cluster/src/local_cluster.rs

@@ -140,7 +140,7 @@ impl LocalCluster {
         match genesis_config.operating_mode {
             OperatingMode::Stable | OperatingMode::Preview => {
                 genesis_config.native_instruction_processors =
-                    solana_genesis_programs::get_programs(genesis_config.operating_mode, 0)
+                    solana_genesis_programs::get_native_programs(genesis_config.operating_mode, 0)
                         .unwrap_or_default()
             }
             _ => (),