Make BPF Loader static #11516
Merged
Make BPF Loader static #11516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
added
work in progress
jackcmay
commented
Aug 10, 2020
|
@mvines These changes are old and in progress but I got stuck and this is blocking the loader optimization I'd like to put in. I added a comment at my stuck point, any suggestions? Another option is to pull the loader into runtime like system_instruction.rs |
jackcmay
force-pushed
the
static-bpf-loader
branch
from
839e925
to
75b3447
Compare
jackcmay
added
noCI
jackcmay
force-pushed
the
static-bpf-loader
branch
from
75b3447
to
c5b94ff
Compare
jackcmay
force-pushed
the
static-bpf-loader
branch
from
c5b94ff
to
16a7a14
Compare
Codecov Report
@@ Coverage Diff @@
## master #11516 +/- ##
=======================================
Coverage 82.0% 82.1%
=======================================
Files 330 330
Lines 76029 76076 +47
=======================================
+ Hits 62405 62475 +70
+ Misses 13624 13601 -23 |
This was referenced Aug 18, 2020
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2020
(cherry picked from commit 7c736f7) # Conflicts: # Cargo.lock # core/Cargo.toml # core/src/lib.rs # core/src/validator.rs # genesis-programs/src/lib.rs # programs/bpf_loader/src/deprecated.rs # programs/bpf_loader/src/lib.rs # sdk/src/entrypoint_native.rs # sdk/src/lib.rs
mergify bot
added a commit
that referenced
this pull request
Aug 22, 2020
* Make BPF Loader static (#11516) (cherry picked from commit 7c736f7) # Conflicts: # Cargo.lock # core/Cargo.toml # core/src/lib.rs # core/src/validator.rs # genesis-programs/src/lib.rs # programs/bpf_loader/src/deprecated.rs # programs/bpf_loader/src/lib.rs # sdk/src/entrypoint_native.rs # sdk/src/lib.rs * resolve conflicts Co-authored-by: Jack May <jack@solana.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2020
(cherry picked from commit 7c736f7) # Conflicts: # Cargo.lock # core/Cargo.toml # core/src/lib.rs # core/src/validator.rs # genesis/src/main.rs # programs/bpf/tests/programs.rs # runtime/src/builtin_programs.rs # runtime/src/lib.rs
mergify bot
added a commit
that referenced
this pull request
Aug 27, 2020
* Make BPF Loader static (#11516) (cherry picked from commit 7c736f7) # Conflicts: # Cargo.lock # core/Cargo.toml # core/src/lib.rs # core/src/validator.rs # genesis/src/main.rs # programs/bpf/tests/programs.rs # runtime/src/builtin_programs.rs # runtime/src/lib.rs * resolve conflicts * nudge Co-authored-by: Jack May <jack@solana.com>
jackcmay
added a commit
to jackcmay/solana
that referenced
this pull request
Aug 27, 2020
)" This reverts commit 81db361.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shared objects get their own instance of jemalloc so alloc/free of pointers across the shared object boundaries blow things up. There are outstanding load optimizations that require this and are currently blocked
Summary of Changes
Make the BPF loader a static program
Fixes #