Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "warnings" from prometheus upstream #168

Closed
wants to merge 16 commits into from
Closed

Conversation

jacksontj
Copy link
Owner

@jacksontj jacksontj commented Jun 14, 2019

Split from #141
TLDR; upstream prometheus added a "storage.Warnings" which it uses for non-primary datasource reads. This pr is for adding support for such a thing

References/links:

@jacksontj
Copy link
Owner Author

Still working through these warnings, at this point I have PRs open for all the ones that are in prom (although it seems that some should have this warning thing...).

Unfortuantely this is a large code change to add warnings as it changes the cleint interface (which means changes at all the layers).

In addition this means we need to determine when promxy will return warnings and not errors :/
Until this point I've been treating any error as fatal, so I'm thinking the "ignore_error" will get a similar companion of "warning_error" (or something similar) that takes al errors and marks them as warnings. This way the client (in config) can be explicit about what failures are tolerable-- and I'll continue to defaulting to requiring non-errors.

Lastly (for now) it also means I need to rework some of the merging logic to take warnings into consideration, if one node returned a "warning" and has no holes, we don't want it to be the primary assuming another one has no holes and has no warnings. Because of these large changes I'm thinking I'll actually split out the

@jacksontj jacksontj mentioned this pull request Jun 14, 2019
@jacksontj jacksontj closed this Jun 15, 2019
@jacksontj jacksontj deleted the prom_2.9_warnings branch June 15, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant