-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "warnings" from prometheus upstream #168
Conversation
Remaining: - remote storage appender -> WAL - Select() warnings
Still working through these warnings, at this point I have PRs open for all the ones that are in prom (although it seems that some should have this warning thing...). Unfortuantely this is a large code change to add warnings as it changes the cleint interface (which means changes at all the layers). In addition this means we need to determine when promxy will return warnings and not errors :/ Lastly (for now) it also means I need to rework some of the merging logic to take warnings into consideration, if one node returned a "warning" and has no holes, we don't want it to be the primary assuming another one has no holes and has no warnings. Because of these large changes I'm thinking I'll actually split out the |
Split from #141
TLDR; upstream prometheus added a "storage.Warnings" which it uses for non-primary datasource reads. This pr is for adding support for such a thing
References/links:
nitial add of warnings to client (Add storage.Warnings to client prometheus/client_golang#562 )rework of warnings in api client (Pass warnings through on non-error responses prometheus/client_golang#599)