Add warnings to series #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I've also opened prometheus/prometheus#5661 as this warnings return seems like it would need to be included in |
|
Is this already in prometheus? can you put a link to the code. |
|
Yes, this is already in prometheus (https://github.com/prometheus/prometheus/blob/master/web/api/v1/api.go#L492). I have opened up the other issue because logically this same |
|
can you add a test for this one as well? |
|
@krasi-georgiev sure, I thought I had already -- but that was for the other PR, here we go :) |
Merged
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
|
@krasi-georgiev that should do it. |
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Jackson jacksontj.89@gmail.com
cc @krasi-georgiev