Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NetSuite dynamic address requirement in 2020.1 release #13

Merged
merged 12 commits into from
Mar 9, 2020

Conversation

merit-sno
Copy link
Contributor

Problem

NetSuite has altered their WSDL, presumably to make dynamic subscriber targeted specifications in the future. This module handles this poorly and during use passes an error specifying that a subscriber based host name is required. Zeep does not manage this, but must use this address.

Solution

Wrap the zeep.transports.transport call with an address manipulator that recognizes and applies the appropriate dynamic domain name to the request. This provides access to production, sandbox, and release preview hosts based upon the initial WSDL definition request.

@merit-sno merit-sno merged commit 37feab0 into jacobsvante:master Mar 9, 2020
@wwatkinson
Copy link

@jmagnusson could you build this to pypi? It enables this package to work with versions beyond 2018.2, which would be really useful.

@jacobsvante
Copy link
Owner

@merit-sno ?

@merit-sno
Copy link
Contributor Author

PyPI repository updated

@wwatkinson
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants