add rcServo,rcIMU,rcBMP functions #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes made to node-roboticscape: jadonk/node-roboticscape#5 tested on: BeagleBone Blue BeagleBoard.org Debian Image 2018-03-05 Linux beaglebone 4.9.105-ti-r113 rc_version : 0.4.4
jadonk
requested changes
Jul 26, 2018
| @@ -18,7 +18,7 @@ var autorun = require('./autorun'); | |||
| var server = require('./server'); | |||
| var socketHandlers = require('./socket_handlers'); | |||
| var ffi = require('./ffiimp'); | |||
| //var rc = require('./rc'); | |||
| var rc = require('./rc'); | |||
There was a problem hiding this comment.
Requires an package.json update to 0.0.8.
There was a problem hiding this comment.
Also, can we use the optional require here in case the package doesn't install nice?
| /*for(var x in rc) { | ||
| exports[x] = rc[x]; | ||
| }*/ | ||
| for (var x in rc) { |
There was a problem hiding this comment.
Can you handle the condition that the library isn't installed nice?
|
@jadonk i have updated the version in package.json ,"roboticscape" is already listed as an optional dependency, so if there is any use of obsolete functions(such as when the installed version of the library is old), shouldn't the optional dependency build fail without affecting other things, also the optional require is used inside rc.js : Line 3 in 0c7c11f |
jadonk
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes made to node-roboticscape: jadonk/node-roboticscape#5
tested on:
BeagleBone Blue BeagleBoard.org Debian Image 2018-03-05
Linux beaglebone 4.9.105-ti-r113
rc_version : 0.4.4