fix compatibility for newer versions & add servo support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaishnavachath
force-pushed
the
master
branch
3 times, most recently
from
4216a54 to
a672afa
Compare
vaishnavachath
added a commit
to vaishnavachath/bonescript
that referenced
this pull request
Jul 20, 2018
changes made to node-roboticscape: jadonk/node-roboticscape#5 tested on: BeagleBone Blue BeagleBoard.org Debian Image 2018-03-05 Linux beaglebone 4.9.105-ti-r113 rc_version : 0.4.4
jadonk
requested changes
Jul 25, 2018
binding.gyp
Outdated
| @@ -2,7 +2,21 @@ | |||
| "targets": [ | |||
| { | |||
| "target_name": "roboticscape", | |||
| "sources": [ "rc-node-bindings.cc" ], | |||
| "variables": { | |||
binding.gyp
Outdated
| "variables": { | ||
| 'RC_version': '<!(rc_version)' | ||
| }, | ||
| "conditions": [ |
There was a problem hiding this comment.
Please use 0.4.4 and obsolete use for the older library. In fact, James has recently made a 1.0.0 release: https://github.com/StrawsonDesign/librobotcontrol/releases/tag/V1.0.0
It should be 0.4.4 compatible, I hope.
rc-node-bindings041.cc
Outdated
| @@ -0,0 +1,504 @@ | |||
| #include <nan.h> | |||
There was a problem hiding this comment.
Please don't create a new file. We can obsolete support for the old API. I'd like to see what changed in this file.
|
submiited #6 after making the recommended changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced some deprecated functions
modified binding.gyp to choose sources based on rc_version
added servo support , used @chnewso 's fork for reference
tested on:
BeagleBone Blue BeagleBoard.org Debian Image 2018-03-05
Linux beaglebone 4.9.105-ti-r113
rc_version : 0.4.4