Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deps] Upgrade jsdom #2585

Closed
yurishkuro opened this issue Jan 11, 2025 · 4 comments · Fixed by #2646
Closed

[Deps] Upgrade jsdom #2585

yurishkuro opened this issue Jan 11, 2025 · 4 comments · Fixed by #2646
Labels
good first issue help wanted

Comments

@yurishkuro
Copy link
Member

The automated upgrade is failing #2584
@yurishkuro yurishkuro changed the title Help upgrading jsdom [Deps] Upgrade jsdom Jan 11, 2025
@Nirpendra09
Copy link

hey @yurishkuro can i take up this task

@yurishkuro
Copy link
Member Author

Yes, you don't have to ask just comment that you are working on it.

@coderboy-yash
Copy link

@yurishkuro I have made a pr for this issue, please review it and tell any changes required for it..

@yurishkuro
Copy link
Member Author

@coderboy-yash if PR is aiming to resolve an issue it should state so in the description so that GitHub links it automatically. I don't see anything new here.

@coderboy-yash coderboy-yash mentioned this issue Jan 21, 2025
Closed
4 tasks
@Srishti-j18 Srishti-j18 mentioned this issue Feb 3, 2025
Closed
3 tasks
@hari45678 hari45678 mentioned this issue Feb 4, 2025
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Feb 5, 2025
@hari45678
Upgrade jsdom to v26 (latest) (#2646)
1f23d07 
## Which problem is this PR solving?
- fixes #2585

## Description of the changes
- Upgrades jsdom to latest version.

## How was this change tested?
- tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
3 participants
@yurishkuro @Nirpendra09 @coderboy-yash