Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BeansXML API for beans.xml file creation. #224

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

manovotn
Copy link
Contributor

Change tests to use this API instead of shrinkwrap descriptors where applicable.
Correct existing beans.xml files to use new namespaces and version 3.0.
Add a simple test of BeansXml API.

Fixes #222

This PR:

  • Removes usage of Shrinkwrap descriptors for beans.xml
    • Note that we still use that for other descriptors which should be amended at some later point and the dependency could than be dropped
  • Changes (hopefully) all beans.xml to use the new namespace and version
  • Adds new BeansXml API that can construct a beans.xml asset which can be added into the constructed test archive

FTR I ran this version against latest Weld (on WildFly) to verify that it works.

Change tests to use this API instead of shrinkwrap descriptors where applicable.
Correct existing beans.xml files to use new namespaces and version 3.0.
Add a simple test of BeansXml API.
@manovotn
Copy link
Contributor Author

Expanded existing BeanDiscoveryTest to also test an explicit bean archive with beans.xml in version 1.1 and 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update beans.xml files to version 3.0
2 participants