Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial prototype of breaking up TCK into a core and web profile set of tests #230

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Initial prototype of breaking up TCK into a core and web profile set of tests #230

merged 2 commits into from
Jun 1, 2021

Conversation

starksm64
Copy link
Contributor

Work in progress

Signed-off-by: Scott M Stark starksm64@gmail.com

@manovotn
Copy link
Contributor

You might want to merge #224 first

@starksm64
Copy link
Contributor Author

You might want to merge #224 first

Ok, will do

starksm64 added 2 commits May 27, 2021 17:27
…f tests

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64
Copy link
Contributor Author

I have remerged the changes from main and gotten the tests to pass against weld master and wildfly-preview-23.0.2.Final
there are some changes that need to be made to the weld/jboss-tck-runner/pom.xml

@manovotn
Copy link
Contributor

manovotn commented Jun 1, 2021

there are some changes that need to be made to the weld/jboss-tck-runner/pom.xml

Ok, please send a PR against Weld.
As soon as there is any CDI API Alpha release, I can swap Weld's default branch to 5.0.0-SNAPSHOT and start accommodating all of these changes. That way we'll have a testable implementation to run all changes against. It should also be fairly easy to adapt WFLY preview to run with even newer CDI/Weld in an automated way (CI) to have the in-container tests covered as well.

BTW the CI build for JDK 8 on this PR is still failing with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cdi-tck-api: Fatal error compiling: invalid flag: --release -> [Help 1]

@starksm64
Copy link
Contributor Author

Java SE 11 is going to be the baseline for CDI 4, and it is possible that is will need to run under Java SE 17. We need to update the CI jobs to move beyond SE 8.

@starksm64 starksm64 changed the title [DO NOT MERGE] Initial prototype of breaking up TCK into a core and web profile set of tests Initial prototype of breaking up TCK into a core and web profile set of tests Jun 1, 2021
@starksm64 starksm64 marked this pull request as ready for review June 1, 2021 14:55
@starksm64 starksm64 merged commit 7f0b5a8 into jakartaee:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants