Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.0/1.9.1 - Breaks compatibility by double quoting characters. #170

Closed
jamielennox opened this issue Apr 29, 2021 · 4 comments
Closed

Comments

@jamielennox
Copy link
Owner

As part of #158, i took the easy way to quote a string and sent it through urlparse.quote merged as part of #162. However if you already have a quoted string (which you would have to have this work until now) this will double quote it and break.

This is a compatibility break and a general bug - sorry, that's my mistake.

I think the right solution here is to do the same thing requests does, so we should use the same quoting logic rather than the simplistic case.

@jamielennox
Copy link
Owner Author

jamielennox commented Apr 29, 2021

I'd prefer to take the option to update this to use the same function as requests (as per #169), rather than revert. @m-melis @ktdreyer @OrangeDog @Cheaterman - can you chime in if this will work for you?

@Cheaterman
Copy link

Cheaterman commented Apr 29, 2021 via email

mfogel added a commit to mfogel/real-backend that referenced this issue Apr 29, 2021
Avoiding upgrading requests-mock to latest as it's got a bug that
affects us: jamielennox/requests-mock#170
mfogel added a commit to mfogel/real-backend that referenced this issue Apr 29, 2021
Avoiding upgrading requests-mock to latest as it's got a bug that
affects us: jamielennox/requests-mock#170
@jamielennox
Copy link
Owner Author

Released as 1.9.2.

Apologies for the break, this was not a very smooth release and i'll be more careful in future,

swhmirror pushed a commit to SoftwareHeritage/swh-web that referenced this issue Apr 30, 2021
…sions"

This reverts commit 50c6b1f.

The issue was coming from a bug in requests-mock that is now fixed
in version 1.9.2 of the package so revert introduced workaround
and exclude buggy versions of requests-mock in requirements-test.

See jamielennox/requests-mock#170
@ktdreyer
Copy link

No problem. requests-mock is a really valuable tool. It's great to see this fixed so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants