Use requests to quote URLs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix to jamielennox#158 didn't match requests' own behavior and quoted a lot of additional characters, causing test breakage. Use `requests.utils.requote_uri` to quote the URL instead, which should ensure the behavior matches requests more closely.
|
Thank you Closes: #170 |
This was referenced Apr 29, 2021
To make sure we don't break this again.
|
1.9 caused some of my tests to fail also. This patch seems to resolve those failures. |
|
I've tested this branch and it works. |
|
Released as 1.9.2. Thanks everyone for the fast feedback, and very sorry this release was chaotic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix to #158 didn't match requests' own behavior and quoted a lot of additional characters, causing test breakage.
Use
requests.utils.requote_urito quote the URL instead, which should ensure the behavior matches requests more closely.I did some brief testing: tests that broke with 1.9.0 (mostly due to
:in the path component) now pass and spaces are now correctly escaped (the original issue mentioned in #158), while leaving most reserved characters untouched.