Build: Generate qm files and embedded resource during build #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Jun 10, 2024
pljones
reviewed
Jun 10, 2024
pljones
reviewed
Jun 10, 2024
softins
force-pushed
the
embed-translations
branch
2 times, most recently
from
384213c
to
e257ad0
Compare
pljones
approved these changes
Jun 11, 2024
ann0see
reviewed
Jun 11, 2024
Previously, translations were embedded manually, via src/resources.qrc Now they are compiled and embedded automatically, using embed_translations, which allows them to be correctly located for multiple targets or archs. Note that RCC_DIR and LRELEASE_DIR can no longer be specified, because the system defaults are necessary for multiple targets/archs to build correctly. The version of Qt must be at least 5.12 for lrelease and embed_translations.
softins
force-pushed
the
embed-translations
branch
from
e257ad0
to
9d0f77c
Compare
The resources generated by embed_translations include the .qm from the filename in the resource name, so it is necessary to remove it. Also, the prefix generated by qmake is /i18n, not /translations.
Now that the .qm files are generated on the fly by the Makefile, a manual lrelease step is no longer needed and wouldn't work correctly.
softins
force-pushed
the
embed-translations
branch
from
9d0f77c
to
05789c6
Compare
|
Once this update is merged, I can follow it up with a PR to easily solve #3092 |
pljones
approved these changes
Jun 17, 2024
ann0see
reviewed
Jun 20, 2024
ann0see
reviewed
Jun 20, 2024
ann0see
added
the
needs documentation
5 tasks
This was referenced Jul 23, 2024
Merged
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Generate the translation .qm files during build and remove them from Github.
CHANGELOG: Build: Generate qm files and embedded resource during build
Context: Fixes an issue?
This replaces previous closed PRs #2393 and #1303
The qm files are binary dependants of the ts text files. Historically they have been generated manually and stored in github. Qt versions from 5.12 include qmake rules for generating and embedding them. After a couple of years of intermittent experimentation, this PR is completely working.
The breakthrough was recently discovered in a Qt bug report. Builds for multiple architectures (e.g. on Android) or targets (Windows defaults to
debug_and_release) only work ifRCC_DIRandLRELEASE_DIRare allowed to default and not specified inJamulus.pro.Does this change need documentation? What needs to be documented and how?
It needs to be made conspicuous that Jamulus will now only build on Qt 5.12 or later.
Jamulus.prowill causeqmaketo exit with an error on earlier (obsolete) versions of Qt.Status of this Pull Request
Working and ready for review.
What is missing until this pull request can be merged?
Just review and general testing.
Checklist