Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TRANSLATING.md now that qm files are built automatically. #3312

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

softins
Copy link
Member

@softins softins commented Jul 15, 2024

Short description of changes
Updates the instructions in TRANSLATING.md to remove references to lrelease and .qm files, now that #3288 provides for the latter to be built automatically. Also add a step to the procedure for adding a new language.

CHANGELOG: Documentation: updated TRANSLATING.md for current build process

Context: Fixes an issue?
Fixes #3310

Does this change need documentation? What needs to be documented and how?
This is documentation!

Status of this Pull Request
Ready for review

What is missing until this pull request can be merged?
Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins added this to the Release 3.11.0 milestone Jul 15, 2024
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@softins
Copy link
Member Author

softins commented Jul 16, 2024

Actually I need to make a couple of changes before merging. It's not necessary to stash the new language file if it has not yet been added to git, and in fact trying to probably wouldn't work. I'll check.

@softins softins requested a review from pljones July 17, 2024 16:34
@softins
Copy link
Member Author

softins commented Jul 17, 2024

Actually I need to make a couple of changes before merging. It's not necessary to stash the new language file if it has not yet been added to git, and in fact trying to probably wouldn't work. I'll check.

Update now added. Should be ready to merge.

@pljones pljones merged commit 9f34684 into jamulussoftware:main Jul 18, 2024
@softins softins deleted the update-translations-md branch July 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TRANSLATING.md for embed_translations
3 participants