Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Only checkout submodules for android #3289

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

softins
Copy link
Member

@softins softins commented Jun 10, 2024

Short description of changes

Only the Android build makes use of the submodule for oboe, so no need to fetch it when building other architectures.

CHANGELOG: Build: checkout of submodules only needed for Android

Context: Fixes an issue?

This just avoids unnecessary work in the CI when building targets other than Android.

Does this change need documentation? What needs to be documented and how?
I wouldn't have thought so.

Status of this Pull Request
Ready

What is missing until this pull request can be merged?
Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Only the Android build makes use of the submodule for oboe,
so no need to fetch it when building other architectures.
@softins softins requested review from pljones and ann0see June 10, 2024 22:04
@softins softins added the tooling Changes to the automated build system label Jun 10, 2024
@softins softins added this to the Release 3.11.0 milestone Jun 10, 2024
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. The build would not succeed if they aren't checked out?

@softins
Copy link
Member Author

softins commented Jun 11, 2024

The build would not succeed if they aren't checked out?

That's correct, because each CI build starts with a clean instance.

@softins softins merged commit c60f955 into jamulussoftware:main Jun 11, 2024
12 checks passed
@softins softins deleted the submodules-only-android branch June 11, 2024 17:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to the automated build system
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants