fix: Remove circular imports and add missing import #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoadesScholar
requested changes
Feb 15, 2024
dacapo/experiments/tasks/post_processors/argmax_post_processor.py
Outdated
Show resolved
Hide resolved
dacapo/experiments/tasks/post_processors/watershed_post_processor.py
Outdated
Show resolved
Hide resolved
| @@ -2,7 +2,6 @@ | |||
| from dacapo.blockwise.scheduler import run_blockwise | |||
| from dacapo.compute_context import ComputeContext, LocalTorch | |||
| from dacapo.experiments.datasplits.datasets.arrays.zarr_array import ZarrArray | |||
| from dacapo.store.array_store import LocalArrayIdentifier | |||
There was a problem hiding this comment.
Needs to still be included
There appear to be some python formatting errors in e42012f. This pull request uses the [psf/black](https://github.com/psf/black) formatter to fix these issues.
One of the files was using `LocalArrayIdentifier`, so in order to remove the circular import entirely we had to empty `store.__init__`. This means that from this point on, all of the `create_*_store` calls need to refer directly to `dacapo.store.create_store`
rhoadesScholar
requested changes
Feb 15, 2024
dacapo/train.py
Outdated
| create_weights_store, | ||
| ) | ||
| from dacapo.experiments import Run | ||
| from dacapo.compute_context import LocalTorch, ComputeContext | ||
| from .validate import validate_run |
There was a problem hiding this comment.
can you make this absolute?
dacapo/experiments/tasks/post_processors/watershed_post_processor.py
Outdated
Show resolved
Hide resolved
rhoadesScholar
requested changes
Feb 15, 2024
dacapo/experiments/tasks/post_processors/watershed_post_processor.py
Outdated
Show resolved
Hide resolved
rhoadesScholar
approved these changes
Feb 15, 2024
|
Make it pass tests please! :) |
rhoadesScholar
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this still does not pass tests.