Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes and better logs #20

Merged
merged 3 commits into from
Feb 7, 2024
Merged

bug fixes and better logs #20

merged 3 commits into from
Feb 7, 2024

Conversation

mzouink
Copy link
Member

@mzouink mzouink commented Feb 7, 2024

No description provided.

Copy link
Member

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Review comments

dacapo/train.py Outdated
f"Found weights for iteration {latest_weights_iteration}, but "
f"run {run.name} was only trained until {trained_until}."
)
# raise RuntimeError(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

dacapo/train.py Outdated
@@ -157,7 +163,7 @@ def train_run(

run.model.eval()
# free up optimizer memory to allow larger validation blocks
run.model = run.model.to(torch.device("cpu"))
# run.model = run.model.to(torch.device("cpu"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about this?

Copy link
Member

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@rhoadesScholar rhoadesScholar merged commit 34e8253 into main Feb 7, 2024
2 of 6 checks passed
@rhoadesScholar rhoadesScholar deleted the zouinkhim_fixes branch February 7, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release
Development

Successfully merging this pull request may close these issues.

2 participants