Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev/main #276

Open
wants to merge 135 commits into
base: dev/main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
7559b5c
feat: 📝 Add Git map PDF
rhoadesScholar Feb 11, 2024
28f9bd6
Revert "feat: 📝 Add Git map PDF"
rhoadesScholar Feb 11, 2024
aaf46b6
Specify resolution with sequences.
vaxenburg May 6, 2024
d81281f
Dev/main (#221)
mzouink May 9, 2024
775744a
Merge branch 'main' into coordinate
rhoadesScholar May 9, 2024
afc7428
Update CONTRIBUTING.md
rhoadesScholar May 9, 2024
82b1abe
update pytest
mzouink May 9, 2024
cc31c01
update tests:
mzouink May 9, 2024
1f03634
Merge branch 'main' into coordinate
rhoadesScholar May 9, 2024
80b21cf
black formatting
mzouink May 9, 2024
12cfd55
fix mypy
mzouink May 9, 2024
9d2384a
update pytest to 8.0.0 (#256)
mzouink May 9, 2024
c306a7c
Merge branch 'main' into coordinate
mzouink May 9, 2024
3c7e309
Specify resolution with sequences (#251)
mzouink May 9, 2024
a3a8f1e
feat: ⚡️ Don't run validation in parallel if you don't distribute wor…
rhoadesScholar May 29, 2024
1b90080
fix: 🐛 Fix LocalTorch distribute_workers
rhoadesScholar May 29, 2024
e88c2c8
support no cli call
mzouink May 30, 2024
f1c7b03
:art: Format Python code with psf/black
mzouink May 30, 2024
7eeb66c
Format Python code with psf/black push (#263)
mzouink May 30, 2024
228bcc9
fix: 🐛 Fix non-cli calls to start blockwise workers.
rhoadesScholar Jun 4, 2024
5a2f22f
chore:
rhoadesScholar Jun 4, 2024
83347b9
support no cli call (#262)
rhoadesScholar Jun 4, 2024
2b1da73
aws docs
mzouink Jun 6, 2024
04c45fe
fix doc formatting
mzouink Jun 6, 2024
a37f288
fix doc formatting
mzouink Jun 6, 2024
9b05d24
fix doc formatting
mzouink Jun 6, 2024
fdc721b
fix doc formatting
mzouink Jun 6, 2024
6e78b42
fix: :bug: fix how file stats are updated
davidackerman Jun 11, 2024
4d6fa63
use negative crops + better neutoglancer
mzouink Jun 13, 2024
4973bf8
black format
mzouink Jun 13, 2024
73bddd8
fix hot_distance
mzouink Jun 17, 2024
5ae701a
Merge branch 'main' into feat_datasplit_use_negativ
mzouink Jun 20, 2024
3b4a5df
fix error run name
mzouink Jun 20, 2024
fed14ef
Merge branch 'feat_datasplit_use_negativ' of https://github.com/janel…
mzouink Jun 20, 2024
26e4e43
:art: Format Python code with psf/black
mzouink Jun 20, 2024
a15e60a
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Jun 25, 2024
d8f6755
Update dependencies and ignore experiment files
rhoadesScholar Jun 25, 2024
a335023
Format Python code with psf/black push (#268)
rhoadesScholar Jun 26, 2024
ee4b183
Merge branch 'main' into fix/store_training_stats
rhoadesScholar Jun 26, 2024
d7a0f21
Merge branch 'main' into docs
rhoadesScholar Jun 27, 2024
cca5064
Update docs.yaml
rhoadesScholar Jun 27, 2024
0a5b796
Merge branch 'main' into docs
rhoadesScholar Jun 27, 2024
a747080
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Jun 27, 2024
d9ccd05
build: 🚑️ Pin fibsem-tools version.
rhoadesScholar Jun 27, 2024
b70b67e
Merge branch 'main' into docs
rhoadesScholar Jun 27, 2024
724955f
Docs (#269)
rhoadesScholar Jun 27, 2024
a2d5750
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Jun 28, 2024
362ab63
feat: ⚡️ Add RescaledArray to handle non-integer resampling.
rhoadesScholar Jul 8, 2024
c7752f5
support no target name in dataset
mzouink Jul 8, 2024
132f0bc
main (#271)
mzouink Jul 8, 2024
95a717a
Merge branch 'main' into feat_datasplit_use_negativ
mzouink Jul 8, 2024
49b1f9e
Rescaled array (#270)
mzouink Jul 8, 2024
9f54ce1
fix: 🐛 Try to fix serialization issues with RescaledArray
rhoadesScholar Jul 8, 2024
0069462
feat: 📝 Add example of simple blockwise segmentation script and funct…
rhoadesScholar Jul 10, 2024
2aab8ad
feat: 📝 Add example of simple blockwise segmentation script and funct…
rhoadesScholar Jul 10, 2024
094acf6
feat: ✨ Add num_lsd_voxel to affinities task config.
rhoadesScholar Jul 10, 2024
b339972
revert: ⏪️ Remove rescaled array (for other branch to merge).
rhoadesScholar Jul 10, 2024
f46735c
Examples/segment blockwise script (#273)
rhoadesScholar Jul 10, 2024
faa777f
Merge branch 'main' into affinities_config
rhoadesScholar Jul 10, 2024
8e60aac
Update segment_script.sh
rhoadesScholar Jul 10, 2024
378d5bb
Merge branch 'affinities_config' of github.com:janelia-cellmap/dacapo…
rhoadesScholar Jul 10, 2024
08fb877
feat: ✨ Add num_lsd_voxel to affinities task config. (#274)
davidackerman Jul 11, 2024
31c7eeb
minor optimizations
mzouink Jul 11, 2024
dec8edd
pull main
mzouink Jul 11, 2024
793e324
revert rescale
mzouink Jul 11, 2024
721784a
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Jul 15, 2024
aba2690
perf: ⚡️ Add found options file to the environment variable.
rhoadesScholar Jul 15, 2024
a89c4f0
dacapo config + minor fixes
mzouink Jul 22, 2024
b649843
Merge branch 'main' into fix/store_training_stats
mzouink Jul 22, 2024
e0cae67
Merge branch 'main' into optional_dep
mzouink Jul 22, 2024
5f6b7ea
perf: ⚡️ Add found options file to the environment variable. (#277)
mzouink Jul 22, 2024
0fa962c
Merge branch 'main' into feat_datasplit_use_negativ
mzouink Jul 22, 2024
8ca78c4
Merge branch 'main' into optional_dep
mzouink Jul 22, 2024
33c6f52
better datasplit generator (#272)
mzouink Jul 22, 2024
9e5ca55
Merge branch 'main' into feat_datasplit_use_negativ
mzouink Jul 22, 2024
e806bf4
use negative crops + better neutoglancer (#267)
mzouink Jul 22, 2024
fb1bd5d
fix: :bug: fix how file stats are updated (#265)
mzouink Jul 22, 2024
6876cac
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Jul 23, 2024
6a6ee1b
fix: 🐛 Fix validation model loading.
rhoadesScholar Jul 23, 2024
926bb2d
better datasplit generator naming
mzouink Jul 23, 2024
aecdadd
Merge branch 'main' into validate_patch
mzouink Jul 23, 2024
9d63428
Merge branch 'validate_patch' of github.com:janelia-cellmap/dacapo in…
rhoadesScholar Jul 25, 2024
e89e2ec
support global_run for local compute context, solve tcp buffer error
mzouink Jul 29, 2024
18ecf1a
Merge branch 'validate_patch' of https://github.com/janelia-cellmap/d…
mzouink Jul 29, 2024
9ea893c
black format
mzouink Jul 29, 2024
0cf9e25
fix plot hack
mzouink Jul 30, 2024
276d481
fix import
mzouink Jul 30, 2024
24c963a
matplotlib plot
mzouink Jul 31, 2024
7f534cf
:art: Format Python code with psf/black
mzouink Jul 31, 2024
86d2bb9
Format Python code with psf/black push (#281)
mzouink Jul 31, 2024
e5c1fbc
Merge branch 'validate_patch' of github.com:janelia-cellmap/dacapo in…
rhoadesScholar Aug 2, 2024
2ed077e
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Aug 2, 2024
8e04c1c
Merge branch 'main' into validate_patch
mzouink Aug 5, 2024
a64c80f
black format
mzouink Aug 5, 2024
e2e9da7
mypy fix
mzouink Aug 5, 2024
4919c91
:art: Format Python code with psf/black
mzouink Aug 5, 2024
2dd89c4
Format Python code with psf/black push (#282)
mzouink Aug 5, 2024
8be4941
fix circular import
mzouink Aug 5, 2024
573d669
fix circular import
mzouink Aug 5, 2024
cab1169
fix validate
mzouink Aug 5, 2024
5e59778
fix tests
mzouink Aug 5, 2024
5a6440b
:art: Format Python code with psf/black
mzouink Aug 5, 2024
c529ed2
Format Python code with psf/black push (#283)
mzouink Aug 5, 2024
d3a55c9
Validate patch (#278)
mzouink Aug 5, 2024
d5196e1
fix new pytorch error
mzouink Aug 5, 2024
a7200c2
Merge branch 'main' into validate_patch
mzouink Aug 5, 2024
8d06bdb
fix new pytorch error
mzouink Aug 5, 2024
b856760
:art: Format Python code with psf/black
mzouink Aug 5, 2024
c0ed0d9
Format Python code with psf/black push (#285)
rhoadesScholar Aug 7, 2024
cc37119
Create CITATION.cff
rhoadesScholar Aug 7, 2024
2e77a18
Update README.md
rhoadesScholar Aug 7, 2024
5bcd5e0
Merge branch 'main' of github.com:janelia-cellmap/dacapo
rhoadesScholar Aug 12, 2024
8e690aa
Merge branch 'main' into validate_patch
rhoadesScholar Aug 12, 2024
36ede1c
Fix small typos
atc3 Aug 12, 2024
9f1f842
Merge branch 'validate_patch' of github.com:janelia-cellmap/dacapo in…
rhoadesScholar Aug 12, 2024
ccc9882
chore: 🙈 Untrack experiment files.
rhoadesScholar Aug 13, 2024
e262537
Merge branch 'main' into typo-fix-240812
mzouink Aug 14, 2024
54e60ad
Merge branch 'main' into validate_patch
mzouink Aug 14, 2024
9682290
fix new pytorch error (#284)
mzouink Aug 14, 2024
54d1df4
Merge branch 'main' into typo-fix-240812
mzouink Aug 14, 2024
4c87b78
Fix small typos (#286)
mzouink Aug 14, 2024
103e9cf
Merge branch 'dev/main' into main
mzouink Aug 14, 2024
bccd778
feat: ✨ Add more extensive pipeline visualize for GunpowderTrainer/Run.
rhoadesScholar Sep 5, 2024
407dd59
fix: 🐛 Fix `datasplit._neuroglancer` bug that happened with binarized…
rhoadesScholar Sep 5, 2024
37c9bea
fix plot bug, retreive fnc is changed
mzouink Sep 10, 2024
d8a77fc
Merge branch 'main' of https://github.com/janelia-cellmap/dacapo
mzouink Sep 10, 2024
f9959f0
support max validation size
mzouink Sep 10, 2024
1cb4748
fix import
mzouink Sep 10, 2024
e4a84ac
:art: Format Python code with psf/black
mzouink Sep 10, 2024
637c53d
Format Python code with psf/black push (#290)
mzouink Sep 10, 2024
5ad40f3
support nD
mzouink Sep 10, 2024
e678aea
Merge branch 'visualize_pipeline'
mzouink Sep 10, 2024
8d0dbf6
force funlib persistence version until we fix new things
mzouink Sep 12, 2024
c0b09bd
Merge branch 'main' into ft_datasplit_gt_limit
mzouink Sep 12, 2024
3430d6a
Feat: datasplit limit validation size (#289)
mzouink Sep 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ jobs:
with:
fetch-depth: 0 # otherwise, you will failed to push refs to dest repo
- name: install dacapo
run: pip install .[docs]
# run: pip install .[docs]
run: pip install sphinx-autodoc-typehints sphinx-autoapi sphinx-click sphinx-rtd-theme myst-parser
- name: Build and Commit
uses: sphinx-notes/pages@v2
with:
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,7 @@ tmp/
# daisy logs
daisy_logs/

*.csv
*.csv
*.private

user_experiments/*
62 changes: 62 additions & 0 deletions CITATION.cff
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@

cff-version: 1.2.0
message: "If you use this software, please cite it as below."
authors:
- family-names: "Patton"
given-names: "William"
orcid: "https://orcid.org/0000-0002-9652-3222"
- family-names: "Rhoades"
given-names: "Jeff L."
orcid: "https://orcid.org/0000-0001-5077-2533"
- family-names: "Zouinkhi"
given-names: "Marwan"
orcid: "https://orcid.org/0000-0002-9441-2908"
- family-names: "Funke"
given-names: "Jan"
orcid: "http://orcid.org/0000-0003-4388-7783"
title: "DaCapo"
version: 0.3.0
doi: 10.48550/arXiv.2408.02834
date-released: 2024-08-05
url: "https://github.com/janelia-cellmap/dacapo"
preferred-citation:
type: article
authors:
- family-names: "Patton"
given-names: "William"
orcid: "https://orcid.org/0000-0002-9652-3222"
- family-names: "Rhoades"
given-names: "Jeff L."
orcid: "https://orcid.org/0000-0001-5077-2533"
- family-names: "Zouinkhi"
given-names: "Marwan"
orcid: "https://orcid.org/0000-0002-9441-2908"
- family-names: "Ackerman"
given-names: "David G."
orcid: "http://orcid.org/0000-0003-0172-6594"
- family-names: "Malin-Mayor"
given-names: "Caroline"
orcid: "https://orcid.org/0000-0002-9627-6030"
- family-names: "Adjavon"
given-names: "Diane"
- family-names: "Heinrich"
given-names: "Larissa"
orcid: "http://orcid.org/0000-0003-2852-6664"
- family-names: "Bennett"
given-names: "Davis"
orcid: "http://orcid.org/0000-0001-7579-2848"
- family-names: "Zubov"
given-names: "Yurii"
orcid: "https://orcid.org/0000-0003-1988-8081"
- family-names: "Project Team"
given-names: "CellMap"
- family-names: "Weigel"
given-names: "Aubrey V."
orcid: "http://orcid.org/0000-0003-1694-4420"
- family-names: "Funke"
given-names: "Jan"
orcid: "http://orcid.org/0000-0003-4388-7783"
doi: 10.48550/arXiv.2408.02834
journal: "arXiv-cs.CV"
title: "DaCapo: a modular deep learning framework for scalable 3D image segmentation"
year: 2024
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ This will also be run automatically when a PR is made to master and a codecov re


## Branching and PRs
- Users that have been added to the CellMap organization and the DaCapo project should be able to develop directly into the CellMap fork of DaCapo. Other users will need to create a fork.
- For a completely new feature, make a branch off of the `dev/main` branch of CellMap's fork of DaCapo with a name describing the feature. If you are collaborating on a feature that already has a branch, you can branch off that feature branch.
- Currently, you should make your PRs into the `dev/main` branch of CellMap's fork, or the feature branch you branched off of. PRs currently require one maintainer's approval before merging. Once the PR is merged, the feature branch should be deleted.
- `dev/main` will be regularly merged to `main` when new features are fully implemented and all tests are passing.
- Users that have been added to the CellMap organization and the DaCapo project should be able to develop directly into the CellMap fork of DaCapo. Other users will need to create a fork or ask to be added as a collaborator.
- For a completely new feature, make a branch off of the `main` branch of CellMap's fork of DaCapo with a name describing the feature. If you are collaborating on a feature that already has a branch, you can branch off that feature branch.
- Currently, you should make your PRs into the `main` branch of CellMap's fork, or the feature branch you branched off of. PRs currently require one maintainer's approval before merging. Once the PR is merged, the feature branch will/should be deleted.
- `main` will be regularly published to PyPi when new features are fully implemented and all tests are passing.


## Documentation
Documentation is built using Sphinx. To build the documentation locally, run
```bash
sphinx-build -M html docs/source docs/build
```
This will generate the html files in the `docs/build/html` directory.
This will generate the html files in the `docs/build/html` directory.
13 changes: 12 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,15 @@ Tasks we support and approaches for those tasks:
- Example of [groundtruth data](https://tinyurl.com/pu8mespz)
- Visualization
- [Neuroglancer GitHub Repo](https://github.com/google/neuroglancer)


# Citing this repo
If you use our code, please cite us and spread the news!
```
@article{Patton_DaCapo_a_modular_2024,
author = {Patton, William and Rhoades, Jeff L. and Zouinkhi, Marwan and Ackerman, David G. and Malin-Mayor, Caroline and Adjavon, Diane and Heinrich, Larissa and Bennett, Davis and Zubov, Yurii and Project Team, CellMap and Weigel, Aubrey V. and Funke, Jan},
doi = {10.48550/arXiv.2408.02834},
journal = {arXiv-cs.CV},
title = {{DaCapo: a modular deep learning framework for scalable 3D image segmentation}},
year = {2024}
}
```
2 changes: 1 addition & 1 deletion dacapo/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
from . import experiments, utils # noqa
from .apply import apply # noqa
from .train import train # noqa
from .validate import validate # noqa
from .validate import validate, validate_run # noqa
from .predict import predict # noqa
from .blockwise import run_blockwise, segment_blockwise # noqa
1 change: 1 addition & 0 deletions dacapo/blockwise/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
from .blockwise_task import DaCapoBlockwiseTask
from .scheduler import run_blockwise, segment_blockwise
from . import global_vars
18 changes: 17 additions & 1 deletion dacapo/blockwise/argmax_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,22 @@ def start_worker(
output_container: Path | str,
output_dataset: str,
return_io_loop: bool = False,
):
return start_worker_fn(
input_container=input_container,
input_dataset=input_dataset,
output_container=output_container,
output_dataset=output_dataset,
return_io_loop=return_io_loop,
)


def start_worker_fn(
input_container: Path | str,
input_dataset: str,
output_container: Path | str,
output_dataset: str,
return_io_loop: bool = False,
):
"""
Start the threshold worker.
Expand Down Expand Up @@ -111,7 +127,7 @@ def spawn_worker(
"""
compute_context = create_compute_context()
if not compute_context.distribute_workers:
return start_worker(
return start_worker_fn(
input_array_identifier.container,
input_array_identifier.dataset,
output_array_identifier.container,
Expand Down
2 changes: 1 addition & 1 deletion dacapo/blockwise/empanada_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def segment_function(input_array, block, **parameters):

Args:
input_array (np.ndarray): The 3D array to segment.
block (dask.array.core.Block): The block object.
block (daisy.Block): The block object.
**parameters: Parameters for the empanada-napari segmenter.
Returns:
np.ndarray: The segmented 3D array.
Expand Down
1 change: 1 addition & 0 deletions dacapo/blockwise/global_vars.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
current_run = None
Loading
Loading