Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/validation (starting from rhoadesj/dev validation related changes) #30

Merged
merged 33 commits into from
Mar 10, 2024
Merged

dev/validation (starting from rhoadesj/dev validation related changes) #30

merged 33 commits into from
Mar 10, 2024

Conversation

rhoadesScholar
Copy link
Member

No description provided.

@rhoadesScholar rhoadesScholar linked an issue Feb 8, 2024 that may be closed by this pull request
Impliment Get_overall_best() #23
Closed
@rhoadesScholar
Copy link
Member Author

@davidackerman I think some of these changes were stolen/adapted from your branches?

@davidackerman
Copy link
Collaborator

davidackerman commented Feb 9, 2024 •
edited
Loading

yeah looks like it!

@rhoadesScholar rhoadesScholar changed the title feat: ⚡️ Incorporaten validation related changes from rhoadesj/dev dev/validation (starting from rhoadesj/dev validation related changes) Feb 11, 2024
@rhoadesScholar rhoadesScholar added bug Something isn't working enhancement New feature or request labels Feb 11, 2024
@rhoadesScholar rhoadesScholar changed the base branch from main to dev/main February 15, 2024 21:51
rhoadesScholar and others added 16 commits February 15, 2024 16:51
@rhoadesScholar
Merge branch 'dev/main' into dev/validation
84a5909
@rhoadesScholar
Merge branch 'dev/validation' into ackermand/dev/validation
dac3d75
@rhoadesScholar
Ackermand/dev/validation (#53)
0776e6d 
Sync all validation changes
@rhoadesScholar
Merge branch 'dev/main' into dev/validation
14ab931
@rhoadesScholar
Merge branch 'dev/main' into dev/validation
d83f23f
@rhoadesScholar
fix: 🐛 Fix validation bugs, and correct training device allocation.
514e547
@rhoadesScholar
feat: ✨ Launch validation in thread to avoid hanging training.
25ecab6
@rhoadesScholar
Add daemon flag to validate_thread
d5058e3
@rhoadesScholar
fix: 🐛 Update predict_worker.py to use daisy directly for block proce…
4461632 
…ssing instead of gunpowder.DaisyRequestBlock.
@rhoadesScholar
Merge branch 'dev/validation' into patch/predict_worker
9e1c4e2
@rhoadesScholar
fix: 🐛 Update predict_worker.py to use daisy directly for block proce… (
5aad373 
#151)

Update predict_worker.py to use daisy.Client for block processing
instead of gunpowder.DaisyRequestBlock.
@rhoadesScholar
fix: 🐛 Fix passing None to daisy.Task and change config specification.
edb2e2c
@rhoadesScholar
fix: 🐛 Fix passing None to daisy.Task and change config specification. (
9a25130 
#152)
@rhoadesScholar
fix: 🐛 Fix compute context creation
1834c72
@rhoadesScholar
Remove commented out code in test_predict.py
144b9e4
@rhoadesScholar
Add print statement to display output array information
0318976
@rhoadesScholar
fix: 🚧 Debugging blockwise
886eb97
@rhoadesScholar
fix: 🐛 Update dependencies and set OPTIONS_FILE environment variable
57e5bd1
@rhoadesScholar
Refactor config store methods to include optional ignore parameter
3159a66
@rhoadesScholar
fix: 🐛 Fixing tests
0db2617
@rhoadesScholar
fix: 🐛 Add sys.executable as the Python interpreter in worker scripts.
66544b8
@rhoadesScholar
fix: ✅ Fix failing daisy-related tests.
c955885 
Additionally: Update project information and dependencies, and add to gitignore.
@rhoadesScholar
Refactor logging statements in code
37ab0bf
@rhoadesScholar
fix: ✅ Fix daisy issues with tests.
6c085d2 
Also added debugging modes for daisy related tests, and updated daisy version dependency.
@rhoadesScholar
fix: 🐛 Fix validation.
2f291cd 
Fixed evaluator and validation loops. Replaced hardcoded test_train threshold. Made tweaks for mypy clearance.
@rhoadesScholar
fix: ✅ Fixed typing declarations.
71e0a59 
Fixed typing declarations to satisfy mypy. Also Black formatted. All tests passing.
rhoadesScholar
rhoadesScholar commented Mar 10, 2024
View reviewed changes
Copy link
Member Author

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

rhoadesScholar
rhoadesScholar commented Mar 10, 2024
View reviewed changes
Copy link
Member Author

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.18367% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 59.79%. Comparing base (bc75625) to head (0a62016).
Report is 191 commits behind head on dev/main.

Files Patch % Lines
dacapo/experiments/tasks/evaluators/evaluator.py 57.50% 17 Missing ⚠️
...experiments/tasks/evaluators/instance_evaluator.py 30.76% 9 Missing ⚠️
dacapo/validate.py 78.04% 9 Missing ⚠️
dacapo/blockwise/empanada_function.py 0.00% 8 Missing ⚠️
dacapo/blockwise/segment_worker.py 0.00% 8 Missing ⚠️
dacapo/cli.py 0.00% 8 Missing ⚠️
dacapo/store/mongo_config_store.py 50.00% 7 Missing ⚠️
dacapo/blockwise/scheduler.py 50.00% 5 Missing ⚠️
dacapo/store/file_config_store.py 75.00% 3 Missing ⚠️
dacapo/train.py 33.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff              @@
##           dev/main      #30      +/-   ##
============================================
- Coverage     64.30%   59.79%   -4.51%     
============================================
  Files           181      190       +9     
  Lines          5483     6296     +813     
============================================
+ Hits           3526     3765     +239     
- Misses         1957     2531     +574

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rhoadesScholar
rhoadesScholar commented Mar 10, 2024
View reviewed changes
Copy link
Member Author

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

@rhoadesScholar rhoadesScholar merged commit ea0564a into dev/main Mar 10, 2024
2 of 4 checks passed
@rhoadesScholar rhoadesScholar deleted the dev/validation branch March 10, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzouink mzouink Awaiting requested review from mzouink

Assignees

@davidackerman davidackerman

Labels
bug Something isn't working enhancement New feature or request
Projects
DaCapo Hackathon 2024
Status: Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impliment Get_overall_best()
2 participants
@rhoadesScholar @davidackerman