Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use kaiming initialization for conv layers #98

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

pattonw
Copy link
Contributor

@pattonw pattonw commented Feb 14, 2024

use kaiming initialization for convolutional layers in dacapo models.
This is important for our standard UNets since the default initialization is pretty terrible when following convolutions with ReLU's.
might want to move this into individual architectures if you are playing around with non ReLU activations

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39915ac) 64.31% compared to head (c140922) 64.35%.
Report is 25 commits behind head on main.

❗ Current head c140922 differs from pull request most recent head f9a58bd. Consider uploading reports for the commit f9a58bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   64.31%   64.35%   +0.03%     
==========================================
  Files         181      181              
  Lines        5479     5482       +3     
==========================================
+ Hits         3524     3528       +4     
+ Misses       1955     1954       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp fix, I agree. But an important one.

@rhoadesScholar rhoadesScholar changed the base branch from main to dev/main February 15, 2024 17:03
@rhoadesScholar rhoadesScholar merged commit 0e834d0 into dev/main Feb 15, 2024
1 of 8 checks passed
@rhoadesScholar rhoadesScholar deleted the kaiming-weight-init branch February 15, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants