This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Fix service raw configuration #203
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b160d84
remove hardcoded images
gazarenkov c659cc9
fix image
gazarenkov 087e105
Update examples/janus-cr-with-app-configs.yaml
gazarenkov 324c295
change lookup
gazarenkov b7dda01
Update config/manager/default-config/db-statefulset.yaml
gazarenkov a20200b
Update config/manager/default-config/deployment.yaml
gazarenkov 100d61a
Merge remote-tracking branch 'origin/images' into images
gazarenkov 5e3a13a
Merge remote-tracking branch 'upstream/main' into images
gazarenkov 6f120f0
change lookup
gazarenkov 63ecb40
change lookup
gazarenkov db63b44
Update config/manager/default-config/deployment.yaml
gazarenkov 3dab91e
add generated files
gazarenkov bd34428
Merge remote-tracking branch 'upstream/main' into images
gazarenkov e5c0607
Merge remote-tracking branch 'origin/images' into images
gazarenkov d103026
fix image
gazarenkov f9f726f
Merge remote-tracking branch 'upstream/main' into images
gazarenkov 7f4ec9d
fix service raw config
gazarenkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding a test case for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, please add note to the issue, will do in a separate PR later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I added a task to issue: #202