Issues with spaces in sysroot path (e.g., Windows user accounts containing spaces)

[AaronCoad]

When using xargo build, the error "Multiple input filenames provided" is returned when the Windows user account contains a space as the folderpath isn't wrapped in double-quotes when passed to rustc --sysroot. In my case C:\Users\Aaron Coad.xargo

On another Windows PC where there is no space within the user account, xargo build works successfully.

[phil-opp]

I tried to add double-quotes in #207, but it seems like they are automatically escaped. I don't have time to work on this at the moment, but in case someone want to try: One possible approach would be to pass the rustc flags directly by invoking cargo rustc and adding them as individual args (instead of invoking cargo build with a manually joined RUSTFLAGS environment variable as it's done currently).

[AxelMontini]

With #221 this should be fixed (escaping using %20 or \ )

[RalfJung]

RUSTFLAGS does not support any kind of escaping, I don't think that would help.

What could help though is to write a .cargo file instead of using an environment variable.

[ZeWaka]

This is still an issue.

[RalfJung]

This is a fundamental limitation in cargo: rust-lang/cargo#6139

There's not much we can do about this on the xargo side, I am afraid.

[kupiakos]

So, it seems the solution is to switch RUSTFLAGS to CARGO_ENCODED_RUSTFLAGS when passing to cargo. Possibly switching based on the cargo version.

If the problem is xargo setting RUSTFLAGS unconditionally then that can be fixed with the recently added feature of CARGO_ENCODED_RUSTFLAGS. This is Cargo's "fix" to the solution for xargo.

rust-lang/cargo#10232 (comment)