Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap sysroot path in double quotes as it might contain spaces #207

Closed
wants to merge 1 commit into from
Closed

Wrap sysroot path in double quotes as it might contain spaces #207

wants to merge 1 commit into from

Conversation

phil-opp
Copy link

@phil-opp phil-opp commented Mar 25, 2018 •
edited
Loading

Fixes #206

@phil-opp phil-opp mentioned this pull request Mar 25, 2018
Closed
@japaric
Copy link
Owner

japaric commented Mar 26, 2018

Thanks @phil-opp.

bors r+

bors bot added a commit that referenced this pull request Mar 26, 2018
@bors
Merge #207
753bd69 
207: Wrap sysroot path in double quotes as it might contain spaces r=japaric a=phil-opp

Fixes #206
@bors
Copy link
Contributor

bors bot commented Mar 26, 2018

Build failed

@phil-opp
Copy link
Author

Seems like cargo/rustc escapes single and double quotes passed in RUSTFLAGS. So this approach doesn't work. I'm not sure how we can work around this…

@phil-opp
Copy link
Author

Unfortunately I don't have the time to work on this at the moment. This seemed like an easy fix, but the auto-escaping makes this more difficult.

@phil-opp phil-opp closed this Apr 10, 2018
@phil-opp phil-opp mentioned this pull request Apr 10, 2018
Closed
@phil-opp phil-opp deleted the sysroot_spaces branch June 11, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @japaric