Filter indices in bukuserver aren't assigned correctly when modifying filter types (thus changing their order in UI)

[LeXofLeviafan]

According to this StackOverflow response (supported by a direct link to the filters parsing code in flask_admin sources):

---

Meanwhile, in bukuserver these indices are assigned incorrectly (not based on filter row position) when modifying filter types (i.e. by adding/selecting in dropdown).

For example…

For the following filters (indices are reassigned when resubmitting the form/changing the page/etc.)…

Changing the type of the first filter to "tags: not contain" (via the dropdown) resulted in the filter index being set to 4, which immediately resulted in the following layout:

And of course, when the filters are resubmitted (after hitting Enter in a filter field, or clicking on a page link in the pagination panel), the parameters list gets reordered according to indices, and the indices are recalculated to match their resulting positions:

---

…Considering that the entire point of these indices is to retain the filter ordering (or modify it if needed), the index assigned when changing filter subtype via dropdown should be retained from the previous value, and when a filter is added its index should be based on its position (amount of filter rows at the moment of appending the new one).

[LeXofLeviafan]

…After some checking, it turns out to be the current behaviour of flask-admin.
I've created a ticket in respective repo to find out if this is indeed a bug or actual intended behaviour; depending on its resolution, this issue can be either cancelled (tentatively) or fixed by updating dependency version once a fix is released.

[jarun]

Thanks for checking!