[bukuserver] Non-conflicting URL parameters in GUI

[LeXofLeviafan]

fixes #635:

• renaming the url param to link in HTML forms & queries (excluding the API)

also:

• clarifying the purpose of BUKUSERVER_SECRET_KEY (in readme)
• normalizing filter parameter indices in statistic.html (see Filter indices in bukuserver aren't assigned correctly when modifying filter types (thus changing their order in UI) #624)
• fixing BUKUSERVER_OPEN_IN_NEW_TAB (broken in current master)
• fixing Little Bobby Tables (as well as incorrectly encoded values)
• adding custom formatting to details page/modal (linebreaks, hyperlink in Url field)

[LeXofLeviafan]

To clarify the last two points:

[rachmadaniHaryono]

note for the pr

• buku only check if url is not empty so whitespace is also valid ' ' see 1
  • but not on bukuserve due to 2
• maybe not set url on anchor tag if scheme is either http or https but no netloc for example http:robert
  • http:robert will link to http://127.0.0.1:5000/bookmark/robert
  • related issue is 3
  • doc on uri 4 and 5
• bookmarklet also work

example of whitespace url on buku

$  python -m buku --nostdin -a '   '
Malformed URL

2653. Untitled
   >

my linter note this on views.py, this could be fixed later

bukuserver/views.py|67 col 12-16 note| "data" is not accessed
bukuserver/views.py|71 col 31-32 error| Argument of type "Literal[0]" cannot be assigned to parameter "__arg1" of type "SupportsRichComparisonT@max" in function "max"   Type "int" cannot be assigned to type "str"     "int" is incompatible with "str"
bukuserver/views.py|96 col 35-39 note| "name" is not accessed
bukuserver/views.py|96 col 41-48 note| "options" is not accessed
bukuserver/views.py|234 col 42-51 note| "sort_desc" is not accessed
bukuserver/views.py|234 col 30-40 note| "sort_field" is not accessed
bukuserver/views.py|244 col 26-39 error| Object of type "None" is not subscriptable
bukuserver/views.py|251 col 21-30 error| Argument of type "Iterable[Any] | list[Any] | list[Unknown]" cannot be assigned to parameter "__obj" of type "Sized" in function "len"   Type "Iterable[Any] | list[Any] | list[Unknown]" cannot be assigned to type "Sized"     "Iterable[Any]" is incompatible with protocol "Sized"       "__len__" is not present
bukuserver/views.py|290 col 34-40 note| "widget" is not accessed
bukuserver/views.py|290 col 47-57 note| "validators" is not accessed
bukuserver/views.py|426 col 41-48 note| "options" is not accessed
bukuserver/views.py|426 col 35-39 note| "name" is not accessed
bukuserver/views.py|490 col 47-57 note| "validators" is not accessed
bukuserver/views.py|490 col 34-40 note| "widget" is not accessed
bukuserver/views.py|500 col 26-30 error| Expression of type "None" cannot be assigned to parameter of type "int"   Type "None" cannot be assigned to type "int"
bukuserver/views.py|605 col 28-32 note| "form" is not accessed

sorry for late review

unrelated but title and description here is actually not stripped

buku/bukuserver/views.py

Lines 205 to 206 in bddc938

	if item.strip():
	kwargs[key] = item

[jarun]

Thank you!

[LeXofLeviafan]

buku only check if url is not empty so whitespace is also valid ' ' see 1
but not on bukuserve due to 2

Well this can be fixed separately if it's actually necessary to be able to support URLs consisting only of whitespace 😄
…Incidentally, the second condition in buku code (url == '') is never checked due to the first one (not url) covering it: empty collections (including strings) are falsey in Python 😅

maybe not set url on anchor tag if scheme is either http or https but no netloc for example http:robert

Makes sense, but I suppose this should be reported as a separate issue (along with the "whitespace URLs" I guess), and it sounds like a fairly low severity issue to me so it can be resolved whenever.

Edit: added #642

unrelated but title and description here is actually not stripped

As far as I can tell, this code simply checks whether the string is blank to decide if it should be used (but doesn't modify user input when using it, which seems like a valid behaviour).

[LeXofLeviafan]

my linter note this on views.py, this could be fixed later

As for this, there's barely anything that could be fixed at all in this list – for the most part the linter here is just getting confused by overloaded methods.