Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL handling in bukuserver #642

Closed
LeXofLeviafan opened this issue Dec 13, 2022 · 1 comment · Fixed by #643
Closed

URL handling in bukuserver #642

LeXofLeviafan opened this issue Dec 13, 2022 · 1 comment · Fixed by #643
Labels

Comments

@LeXofLeviafan
Copy link
Collaborator

As of now, bukuserver creates hyperlinks to "invalid" URLs (those without a netloc) – this should be amended.

In addition, URL input validation in the UI form differs from buku: buku only rejects empty values, while bukuserver rejects any blank URLs (i.e. whitespace-only).

@LeXofLeviafan
Copy link
Collaborator Author

LeXofLeviafan commented Dec 13, 2022

…Note: I've changed blank check in the code, but whitespace-only URLs are still rejected by the "required" validator in the form itself.

Nevermind, there's an alternative InputRequired validator (which is actually preferred according to the docs) that allows whitespace-only inputs.

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Dec 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant