Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: the repo fails to clone on Windows #666

Closed
LeXofLeviafan opened this issue Jan 23, 2023 · 0 comments · Fixed by #668
Closed

Regression: the repo fails to clone on Windows #666

LeXofLeviafan opened this issue Jan 23, 2023 · 0 comments · Fixed by #668
Labels

Comments

@LeXofLeviafan
Copy link
Collaborator

As per the title, the current version of the repo fails to clone on Windows due to the filesystem limitations: it crashes midway with an error message about a filename being too long. The result is a repo clone with half of the files missing (which can be confirmed by git status), and using the command git restore --staged * creates all of the missing files except for the one that caused the error.

The file in question is the cassette for google network handler test; it includes the entire URL (with some characters replaced by dashes, but still), and thus doesn't fit within the Windows filepath limits (270 chars of 260 allowed).

Proposed fix: custom test case IDs

P.S. …Actually, what's up with the cassette files organisation? Some are placed in tests/vcr_cassettes/, others in tests/vcr_cassettes/tests.test_bukuDb/, and others yet in tests/cassettes/test_buku/. Shouldn't they either be in one folder, or one per testfile but named accordingly (and gathered in one place)?

This was referenced Jan 23, 2023
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant