Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes for testing bugs #668

Merged
merged 1 commit into from
Jan 23, 2023
Merged

small fixes for testing bugs #668

merged 1 commit into from
Jan 23, 2023

Conversation

LeXofLeviafan
Copy link
Collaborator

fixes #666:

  • removing URL queries from testcase IDs for test_network_handler_with_url (thus shortening cassette names)

fixes #667:

  • removing dependency on external binary for pylint validation

also:

  • removing a no-longer-default check from pylint disable list to get rid of the warning
  • adding a venv/ folder to linter exceptions to allow for convenient virtualenv placement
  • updating flask-reverse-proxy-fix version in bukuserver/requirements.txt to match setup.py

P.S. Is it actually necessary for .pylintrc to be placed in tests/? It's used globally, so it would make more sense to just move it into the repo root and not have to specify a path. It would also allow to move path exceptions into the config file.

@jarun jarun merged commit f32ed53 into jarun:master Jan 23, 2023
@jarun
Copy link
Owner

jarun commented Jan 23, 2023

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
@LeXofLeviafan LeXofLeviafan deleted the tests-fix branch August 24, 2024 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox.ini doesn't work with latest version of tox Regression: the repo fails to clone on Windows
2 participants