Adjust step for r-dependencies installation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandenman
reviewed
Dec 22, 2022
vandenman
approved these changes
Dec 22, 2022
shun2wang
force-pushed
the
adjust_unittests
branch
3 times, most recently
from
8dc6dd5
to
78c7aa8
Compare
shun2wang
requested review from
vandenman
and removed request for
Kucharssim
Signed-off-by: Shun Wang <shuonwang@gmail.com>
shun2wang
force-pushed
the
adjust_unittests
branch
from
78c7aa8
to
2f536c3
Compare
|
@vandenman Do you have time look this?It will be smoother for unit testing. thanks |
|
I think this looks fine so I'll merge it. We should probably follow that issue so we can remove |
Yeah, I had do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jaspToolsby r-dependencies, avoid duplicate installation of some packages (remotes, ragg), because repeated installation ofraggwill indeed bring unexpected errors,jaspBasestill be installed twice, but as Don said it needs to be set insidejaspTools.Cleanigraphand install it from CRAN,pakwill set it by default.See test branch and run logs for more details, and here in sessionInfo you can see the source of all packages .