downstream support for get_data implementation #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
mask_subset
in the private_get_data
method which applies any generic subset as a mask.spectral_subset
is then a special case of thismask_subset
where type-checks are done to ensure its spectral. Downstream apps (such as lcviz - see this PR for required changes there if this is adopted) can then write their ownget_data
method which does its own type-checks, if necessary, and passes any type of subset tomask_subset
(as long as it doesn't also passspectral_subset
).