update for upstream changes to get_data #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
13 tasks
This was referenced May 24, 2023
kecnry
commented
May 25, 2023
Comment on lines
+100
to
+155
| subset : str, optional | ||
| Subset that is to be applied (as a mask) to the data before it is returned. |
There was a problem hiding this comment.
eventually we might want a separate spatial_subset that can be applied to TPFs for extraction of light curves... if/when that happens, we could consider renaming this to temporal_subset (or we could do it now if everyone thinks that would be more clear... I'm just worried that it could still be a bit confusing since they can be in either phase or time-space).
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 15 15
Lines 693 693
=======================================
Hits 579 579
Misses 114 114
☔ View full report in Codecov by Sentry. |
bmorris3
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be needed if spacetelescope/jdaviz#2199 and
javerbukh/jdaviz#15spacetelescope/jdaviz#2214 are adopted upstream to support temporal subsets.