Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for upstream changes to get_data #20

Merged
merged 1 commit into from
May 25, 2023
Merged

update for upstream changes to get_data #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lcviz/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def load_data(self, data, data_label=None):
data_label=data_label
)

def get_data(self, data_label=None, cls=LightCurve, subset_to_apply=None):
def get_data(self, data_label=None, cls=LightCurve, subset=None):
"""
Returns data with name equal to data_label of type cls with subsets applied from
subset_to_apply.
Expand All @@ -151,12 +151,12 @@ def get_data(self, data_label=None, cls=LightCurve, subset_to_apply=None):
Provide a label to retrieve a specific data set from data_collection.
cls : light curve class, optional
The type that data will be returned as.
subset_to_apply : str, optional
Subset that is to be applied to data before it is returned.
subset : str, optional
Subset that is to be applied (as a mask) to the data before it is returned.
Comment on lines +154 to +155
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually we might want a separate spatial_subset that can be applied to TPFs for extraction of light curves... if/when that happens, we could consider renaming this to temporal_subset (or we could do it now if everyone thinks that would be more clear... I'm just worried that it could still be a bit confusing since they can be in either phase or time-space).


Returns
-------
data : cls
Data is returned as type cls with subsets applied.
"""
return super()._get_data(data_label=data_label, cls=cls, subset_to_apply=subset_to_apply)
return super()._get_data(data_label=data_label, mask_subset=subset, cls=cls)